Re: pgAdmin IV- Testing framework: Enhanced Test Result Summary

From: Navnath Gadakh <navnath(dot)gadakh(at)enterprisedb(dot)com>
To: Dave Page <dave(dot)page(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>, Kanchan Mohitey <kanchan(dot)mohitey(at)enterprisedb(dot)com>
Subject: Re: pgAdmin IV- Testing framework: Enhanced Test Result Summary
Date: 2016-09-19 07:14:11
Message-ID: CAOAJCYphLQh5=qtEFG3i4x4yf_FqWGtrLjB_Uvh1gq8Bmx9mcQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi Dave,
Error resolved. Please find the revised patch.

On Fri, Sep 16, 2016 at 9:23 PM, Dave Page <dave(dot)page(at)enterprisedb(dot)com>
wrote:

> Hi
>
> On Fri, Sep 16, 2016 at 2:37 PM, Navnath Gadakh
> <navnath(dot)gadakh(at)enterprisedb(dot)com> wrote:
> > Hi Dave,
> > Please find the patch for the enhanced test result summary for
> testing
> > framework. The code for this, was completed before drop object's
> > functionality & independent from drop objects work.
> > Drop objects work will take time, I am working on that for remaining
> nodes.
> > Meanwhile, we go ahead with enhanced test summary.
> >
> > To run the test suite follow the commands
> > 1. python regression/runtests.py --pkg browser.server_groups.servers
> > 2. python regression/runtests.py --pkg
> > browser.server_groups.servers.databases
>
> I'm seeing some issues with this patch:
>
> - There are updates to config.py and setup.py that shouldn't be there.
> - I get this error at the end of a successful test run:
>
> Test Result Summary
> ============================
> Regression - PG 9.4: 25 tests passed, 0 tests failed
> ============================
>
> Please check output in file:
> /Users/dpage/git/pgadmin4/web/regression/regression.log
> Error in atexit._run_exitfuncs:
> Traceback (most recent call last):
> File "/System/Library/Frameworks/Python.framework/Versions/2.7/
> lib/python2.7/atexit.py",
> line 24, in _run_exitfuncs
> func(*targs, **kargs)
> File "/Users/dpage/git/pgadmin4/web/regression/test_utils.py", line
> 360, in drop_objects
> file_name, sys.exc_traceback.tb_lineno, exception))
> Exception: test_utils.py: line:337 'NoneType' object has no attribute
> '__getitem__'
> Error in sys.exitfunc:
> Traceback (most recent call last):
> File "/System/Library/Frameworks/Python.framework/Versions/2.7/
> lib/python2.7/atexit.py",
> line 24, in _run_exitfuncs
> func(*targs, **kargs)
> File "/Users/dpage/git/pgadmin4/web/regression/test_utils.py", line
> 360, in drop_objects
> file_name, sys.exc_traceback.tb_lineno, exception))
> Exception: test_utils.py: line:337 'NoneType' object has no attribute
> '__getitem__'
>
>
Thanks.

> --
> Dave Page
> VP, Chief Architect, Tools & Installers
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>

--
Regards,
Navnath

Attachment Content-Type Size
enhanced_testresult_summary.patch application/octet-stream 37.9 KB

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Murtuza Zabuawala 2016-09-19 07:20:20 PATCH: To fix the issue in Packages node (pgAdmin4)
Previous Message Seçkin Alan 2016-09-18 19:27:51 pgAdmin 4 in the two bugs