Re: Server specific advanced config file for testsuite

Hi,

On Tue, Sep 13, 2016 at 2:18 PM, Dave Page <dave(dot)page(at)enterprisedb(dot)com>
wrote:

> BTW - I need the updated code that fixes all outstanding issues this
> week please. Release is coming up fast...

Yes. The enhanced test result is already completed, but before that drop
objects functionality is needed to complete. Which is already done for
servers & databases. So I will send a patch for these two nodes today &
after that for the remaining nodes(need some modifications
in existing setup & teardown for each test module)

We will try to finish this work end of this week.

Thanks.

>

> On Tue, Sep 13, 2016 at 9:48 AM, Dave Page <dave(dot)page(at)enterprisedb(dot)com>
> wrote:
> > Hi
> >
> > On Mon, Sep 12, 2016 at 6:26 PM, Navnath Gadakh
> > <navnath(dot)gadakh(at)enterprisedb(dot)com> wrote:
> >> Hi Dave,
> >> As we know that, we are using two JSON files one is for basic
> >> configuration of server(test_config.json) and second for detailed
> >> configuration of server(test_advanced_config.json).
> >> In test_advanced_config.json, we give detail for database, schema,
> >> extension, collation etc. These details are generic I mean these
> details are
> >> not server specific.
> >> - Do we need to allow user to give server specific details?
> >
> > I don't see any reason to do so. Honestly I don't see much need for
> > test_advanced_config.json at all - I can't see anyone ever customising
> > the tests. I certainly doubt I will.
> >
> >> If yes, there should be some identification(like ‘server_type’,
> ‘version’)
> >> for each detail so that we can read server appropriate details.
> >> We have one approach in mind, to attach 'server_type' & 'version' to
> each
> >> detail
> >> So, modified test_advanced_config.json can be like this,
> >> {
> >> "add_database_data”:[
> >> {
> >> "conn_limit": -1,
> >> “owner”: “postres”,
> >> .
> >> .
> >> .
> >> .
> >> “server_type”: “pg”,
> >> “version”: “pg9.4”
> >> },
> >> {
> >> {
> >> "conn_limit": -1,
> >> “owner”: “enterprisedb”,
> >> .
> >> .
> >> .
> >> .
> >> “server_type”: “ppas”,
> >> “version”: “ppas9.6”
> >> }
> >> }],
> >> “schema_credentials”:
> >> [{"func_acl": [],
> >> "seq_acl": [],
> >> .
> >> .
> >> .
> >> .
> >> “server_type”: “pg”,
> >> “version”: “pg9.4”
> >> }]
> >> .
> >> .
> >> .
> >> .
> >> .
> >> }
> >>
> >> Any suggestions?
> >>
> >> For multiple server currently we used 'owner' to identify the server,
> but
> >> that fails if two servers have the same owner.
> >>
> >>
> >> --
> >> Thanks,
> >> Navnath Gadakh
> >> Software Engineer
> >> EnterpriseDB Corporation
> >> Mobile: +91 9975389878
> >>
> >>
> >
> >
> >
> > --
> > Dave Page
> > VP, Chief Architect, Tools & Installers
> > EnterpriseDB: http://www.enterprisedb.com
> > The Enterprise PostgreSQL Company
> >
> > Blog: http://pgsnake.blogspot.com
> > Twitter: @pgsnake
>
>
>
> --
> Dave Page
> VP, Chief Architect, Tools & Installers
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>

--
Thanks,
Navnath Gadakh
Software Engineer
EnterpriseDB Corporation
Mobile: +91 9975389878