| From: | Anthonin Bonnefoy <anthonin(dot)bonnefoy(at)datadoghq(dot)com> |
|---|---|
| To: | Alena Rybakina <lena(dot)ribackina(at)yandex(dot)ru> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
| Subject: | Re: Fix parallel vacuum buffer usage reporting |
| Date: | 2024-04-22 08:07:33 |
| Message-ID: | CAO6_XqrJeHrPtE9z0dt3O9xqq3097-LWO9xNYbnjh_iMmurzgw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sat, Apr 20, 2024 at 2:00 PM Alena Rybakina <lena(dot)ribackina(at)yandex(dot)ru>
wrote:
> Hi, thank you for your work with this subject.
>
> While I was reviewing your code, I noticed that your patch conflicts with
> another patch [0] that been committed.
>
> [0]
> https://www.postgresql.org/message-id/flat/CA%2BhUKGJkOiOCa%2Bmag4BF%2BzHo7qo%3Do9CFheB8%3Dg6uT5TUm2gkvA%40mail.gmail.com
>
I've rebased the patch and also split the changes:
1: Use pgBufferUsage in Vacuum and Analyze block reporting
2: Stop tracking buffer usage in the now unused Vacuum{Hit,Miss,Dirty}
variables
3: Remove declarations of Vacuum{Hit,Miss,Dirty}
| Attachment | Content-Type | Size |
|---|---|---|
| v3-0003-Remove-declaration-of-Vacuum-block-usage-tracking.patch | application/octet-stream | 1.4 KB |
| v3-0001-Fix-parallel-vacuum-buffer-usage-reporting.patch | application/octet-stream | 6.1 KB |
| v3-0002-Remove-unused-tracking-of-vacuum-buffer-usage.patch | application/octet-stream | 2.8 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | jian he | 2024-04-22 08:43:42 | slightly misleading Error message in guc.c |
| Previous Message | Alexander Lakhin | 2024-04-22 08:00:00 | Re: Optimizing nbtree ScalarArrayOp execution, allowing multi-column ordered scans, skip scan |