| From: | Anthonin Bonnefoy <anthonin(dot)bonnefoy(at)datadoghq(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Jelte Fennema-Nio <postgres(at)jeltef(dot)nl>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [PATCH] Add additional extended protocol commands to psql: \parse and \bindx |
| Date: | 2024-01-18 08:25:16 |
| Message-ID: | CAO6_Xqr7kUtEv8UrWtYx33tksAwMehHiwaBJxyV9XmL0RVpZiA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> Hmm. So it does not lead to any user-visible changes, right?
From what I can tell, there's no change in the behaviour. All paths
would eventually go through HandleSlashCmds's cleaning logic. This is
also mentioned in ignore_slash_options's comment.
* Read and discard "normal" slash command options.
*
* This should be used for inactive-branch processing of any slash command
* that eats one or more OT_NORMAL, OT_SQLID, or OT_SQLIDHACK parameters.
* We don't need to worry about exactly how many it would eat, since the
* cleanup logic in HandleSlashCmds would silently discard any extras anyway.
> Could you split the bits for \bind into a separate patch, please?
> This requires a separate evaluation, especially if this had better be
> backpatched.
Done. patch 1 adds ignore_slash_options to bind. patch 2 adds the new
\bindx, \close and \parse commands.
| Attachment | Content-Type | Size |
|---|---|---|
| v4-0002-psql-Add-support-for-prepared-stmt-with-extended-.patch | application/octet-stream | 19.7 KB |
| v4-0001-psql-Add-ignore_slash_options-in-bind-s-inactive-.patch | application/octet-stream | 1.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Kyotaro Horiguchi | 2024-01-18 08:26:31 | Re: Network failure may prevent promotion |
| Previous Message | Peter Eisentraut | 2024-01-18 08:17:11 | Re: add function argument names to regex* functions. |