| From: | Anthonin Bonnefoy <anthonin(dot)bonnefoy(at)datadoghq(dot)com> |
|---|---|
| To: | "Imseih (AWS), Sami" <simseih(at)amazon(dot)com> |
| Cc: | Andrei Lepikhov <lepihov(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, kaido vaikla <kaido(dot)vaikla(at)gmail(dot)com>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: query_id, pg_stat_activity, extended query protocol |
| Date: | 2024-07-17 09:32:49 |
| Message-ID: | CAO6_XqqYLU0Qw1YkjdOM8ciJ9UsUGccRgQyNhR=R=YJuZkU5jA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
Wouldn't it be enough to call pgstat_report_query_id in ExecutorRun
and ProcessUtility? With those changes [1], both normal statements and
utility statements called through extended protocol will correctly
report the query_id.
-- Test utility statement with extended protocol
show all \bind \g
-- Check reported query_id
select query, query_id from pg_stat_activity where
application_name ='psql' and pid!=pg_backend_pid();
query | query_id
-----------+---------------------
show all | -866221123969716490
[1] https://github.com/bonnefoa/postgres/commit/bf4b332d7b481549c6d9cfa70db51e39a305b9b2
Regards,
Anthonin
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Matthias van de Meent | 2024-07-17 09:33:05 | Re: Expand applicability of aggregate's sortop optimization |
| Previous Message | Nazir Bilal Yavuz | 2024-07-17 09:22:49 | Re: Use read streams in CREATE DATABASE command when the strategy is wal_log |