From: | Anthonin Bonnefoy <anthonin(dot)bonnefoy(at)datadoghq(dot)com> |
---|---|
To: | Jelte Fennema-Nio <postgres(at)jeltef(dot)nl> |
Cc: | PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: [PATCH] Add additional extended protocol commands to psql: \parse and \bindx |
Date: | 2024-01-16 08:13:17 |
Message-ID: | CAO6_XqqGScQuGbkzoH90Rb-eD0hJtaYGMCs4akgTEocGanw0sQ@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hi,
Thanks for the review and comments.
> One thing that I think should be added for completeness though is the
> ability to deallocate the prepared statement using
> PQsendClosePrepared. Other than that the changes look great.
Good point, I've added the \close command.
> Also a tiny nitpick: stmt_name should be replaced with STMT_NAME in
> this line of the help message.
Fixed
On Sat, Jan 13, 2024 at 3:37 PM Jelte Fennema-Nio <postgres(at)jeltef(dot)nl> wrote:
>
> On Thu, 2 Nov 2023 at 10:52, Anthonin Bonnefoy
> <anthonin(dot)bonnefoy(at)datadoghq(dot)com> wrote:
> > The main goal is to provide more ways to test extended protocol in
> > regression tests
> > similarly to what \bind is doing.
>
> I think this is a great addition. One thing that I think should be
> added for completeness though is the ability to deallocate the
> prepared statement using PQsendClosePrepared. Other than that the
> changes look great.
>
> Also a tiny nitpick: stmt_name should be replaced with STMT_NAME in
> this line of the help message.
>
> > + HELP0(" \\bindx stmt_name [PARAM]...\n"
Attachment | Content-Type | Size |
---|---|---|
v2-0001-psql-Add-support-for-prepared-stmt-with-extended-.patch | application/octet-stream | 18.8 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Konstantin Knizhnik | 2024-01-16 08:13:43 | Re: index prefetching |
Previous Message | Richard Guo | 2024-01-16 08:00:09 | Re: Revise the Asserts added to bimapset manipulation functions |