From: | Anthonin Bonnefoy <anthonin(dot)bonnefoy(at)datadoghq(dot)com> |
---|---|
To: | Michael Paquier <michael(at)paquier(dot)xyz> |
Cc: | Peter Eisentraut <peter(at)eisentraut(dot)org>, Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, Jelte Fennema-Nio <postgres(at)jeltef(dot)nl>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: [PATCH] Add additional extended protocol commands to psql: \parse and \bind |
Date: | 2024-07-25 06:45:28 |
Message-ID: | CAO6_XqpG3a0cCHkhc1HGPGrkNqCttbM3UCqnSTEn+zFCau6Baw@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Wed, Jul 24, 2024 at 05:33:07PM +0200, Peter Eisentraut wrote:
> This commit message confused me, because I don't think this is what the
> \bindx command actually does. AFAICT, it only binds, it does not execute.
> At least that is what the documentation in the content of the patch appears
> to indicate.
Unless I misunderstand the remark, \bindx will call
PQsendQueryPrepared which will bind then execute the query, similar to
what \bind is doing (except \bind also parses the query).
> I'm not sure \bindx is such a great name. The "x" stands for "I ran out of
> ideas". ;-)
That's definitely what happened :). \bind would have been a better fit
but it was already used.
On Thu, Jul 25, 2024 at 4:19 AM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
> Not sure that I like much the additional option embedded in the
> existing command; I'd rather keep a separate command for each libpq
> call, that seems cleaner. So I would be OK with your suggested
> \bind_named. Fine by me to be outvoted, of course.
+1 keeping this as a separate command and using \bind_named. \bind has
a different behaviour as it also parses the query so keeping them as
separate commands would probably avoid some confusion.
From | Date | Subject | |
---|---|---|---|
Next Message | Peter Smith | 2024-07-25 07:24:28 | Re: Logical Replication of sequences |
Previous Message | shveta malik | 2024-07-25 06:38:19 | Re: Logical Replication of sequences |