| From: | Anthonin Bonnefoy <anthonin(dot)bonnefoy(at)datadoghq(dot)com> |
|---|---|
| To: | Dilip Kumar <dilipbalaut(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Remove dependency on VacuumPage(Hit/Miss/Dirty) counters in do_analyze_rel |
| Date: | 2024-06-06 09:52:59 |
| Message-ID: | CAO6_XqogeCHKfzJcyspGvLyRaDH+q424wSM_pcbZtwaqRtThxA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
I sent a similar patch for this in
https://www.postgresql.org/message-id/flat/CAO6_Xqr__kTTCLkftqS0qSCm-J7_xbRG3Ge2rWhucxQJMJhcRA(at)mail(dot)gmail(dot)com
Regards,
Anthonin
On Thu, Jun 6, 2024 at 11:10 AM Dilip Kumar <dilipbalaut(at)gmail(dot)com> wrote:
> As part of commit 5cd72cc0c5017a9d4de8b5d465a75946da5abd1d, the
> dependency on global counters such as VacuumPage(Hit/Miss/Dirty) was
> removed from the vacuum. However, do_analyze_rel() was still using
> these counters, necessitating the tracking of global counters
> alongside BufferUsage counters.
>
> The attached patch addresses the issue by eliminating the need to
> track VacuumPage(Hit/Miss/Dirty) counters in do_analyze_rel(), making
> the global counters obsolete. This simplifies the code and improves
> consistency.
>
> --
> Regards,
> Dilip Kumar
> EnterpriseDB: http://www.enterprisedb.com
>
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alexander Lakhin | 2024-06-06 10:00:00 | Assert in heapgettup_pagemode() fails due to underlying buffer change |
| Previous Message | Amit Kapila | 2024-06-06 09:40:06 | Re: Logical Replication of sequences |