Re: BUG #18456: Trigger data in plpython3u trigger-function changes in AFTER UPDATE OR INSERT trigger

Exhibit A. Will remember to keep signatures and stuff out of these mails.

Regards
Jacques Combrink

On Mon, May 6, 2024 at 10:23 AM Jacques Combrink <
jacques(at)quantsolutions(dot)co(dot)za> wrote:

> Okay thanks for confirming.
>
> Is there something that I can do to get this issue on a list to be fixed,
> or is this report enough?
>
> Sorry for the questions, first time posting here, not sure how everything
> works.
>
> Regards
> [image: GoodX Logo] <https://www.goodx.healthcare>
> Jacques Combrink
> Software Developer
>
> [image: telephone] 012 845 9888
> [image: emailad] jacques(at)quantsolutions(dot)co(dot)za
>
> [image: GoodX Website] <https://www.goodx.healthcare> [image: GoodX
> YouTube] <https://www.youtube.com/channel/UCX235mj63BB9gb9YUSxe7Bg> [image:
> GoodX Facebook] <https://www.facebook.com/GoodXSoftware/> [image: GoodX
> LinkedIn] <https://www.linkedin.com/company/goodx-software/> [image:
> GoodX Instagram] <https://www.instagram.com/goodx_software/>
>
> [image: GoodX Group Logos] <https://www.goodx.healthcare>
>
>
> On Sat, May 4, 2024 at 8:34 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>
>> PG Bug reporting form <noreply(at)postgresql(dot)org> writes:
>> > Then the trigger data changes after the insert statement in the trigger
>> > function.
>>
>> Hmm. TD is defined as a global dictionary like SD, so it saves values
>> across calls to the plpython function. So the inner INSERT operation
>> fires the same trigger, which decides not to print anything, but
>> nonetheless it's changed TD and the outer trigger call will see that.
>>
>> There used to be similar problems in plain plpython functions if they
>> were invoked recursively, because named function arguments are also
>> passed as global variables. We fixed that in a rather hacky way in
>> 1d2fe56e4, ie save and restore those globals when recursing.
>> Probably the same thing could be done with TD.
>>
>> regards, tom lane
>>
>