From: | Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com> |
---|---|
To: | Aditya Toshniwal <aditya(dot)toshniwal(at)enterprisedb(dot)com> |
Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: [pgAdmin][RM6177] ERD download image related fixes |
Date: | 2021-01-29 06:50:18 |
Message-ID: | CANxoLDfxVugTihpCJDGJGopdUy3OBBD3weD_7PadximeGfMNBw@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Thanks, patch applied.
On Fri, Jan 29, 2021 at 12:05 PM Aditya Toshniwal <
aditya(dot)toshniwal(at)enterprisedb(dot)com> wrote:
> Hi,
>
> Attached is the patch based on the latest code base.
>
> On Fri, Jan 29, 2021 at 11:58 AM Akshay Joshi <
> akshay(dot)joshi(at)enterprisedb(dot)com> wrote:
>
>> Hi Aditya
>>
>> I think you forgot to attach the patch.
>>
>> On Thu, Jan 28, 2021 at 4:35 PM Aditya Toshniwal <
>> aditya(dot)toshniwal(at)enterprisedb(dot)com> wrote:
>>
>>> Hi Hackers,
>>>
>>> Attached is the patch to:
>>> 1) Icons were not visible in downloaded images. Fixed.
>>> 2) Download image will now work on Safari and Firefox also.
>>> 3) Added the icon of foreign key to the "many" endpoint of one to many
>>> links.
>>> [image: image.png]
>>>
>>> Please review.
>>>
>>> --
>>> Thanks,
>>> Aditya Toshniwal
>>> pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com*
>>> <http://edbpostgres.com>
>>> "Don't Complain about Heat, Plant a TREE"
>>>
>>
>>
>> --
>> *Thanks & Regards*
>> *Akshay Joshi*
>> *pgAdmin Hacker | Principal Software Architect*
>> *EDB Postgres <http://edbpostgres.com>*
>>
>> *Mobile: +91 976-788-8246*
>>
>
>
> --
> Thanks,
> Aditya Toshniwal
> pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com*
> <http://edbpostgres.com>
> "Don't Complain about Heat, Plant a TREE"
>
--
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Principal Software Architect*
*EDB Postgres <http://edbpostgres.com>*
*Mobile: +91 976-788-8246*
From | Date | Subject | |
---|---|---|---|
Next Message | Akshay Joshi | 2021-01-29 08:10:35 | pgAdmin 4 commit: Implemented runtime using NWjs to open pgAdmin4 in a |
Previous Message | Akshay Joshi | 2021-01-29 06:49:32 | pgAdmin 4 commit: Fixed an issue while downloading ERD images in Safari |