Re: [pgAdmin4][Patch]: RM 3697 Detached Data Output Tab (Windows) does not show Select output

From: Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
To: Aditya Toshniwal <aditya(dot)toshniwal(at)enterprisedb(dot)com>
Cc: Dave Page <dpage(at)pgadmin(dot)org>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin4][Patch]: RM 3697 Detached Data Output Tab (Windows) does not show Select output
Date: 2019-01-29 13:20:03
Message-ID: CANxoLDfem8xmqw8465SGmQTFNT0+2DkYXJatY8oLQw3-Bsc3rg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

On Tue, Jan 29, 2019 at 6:27 PM Aditya Toshniwal <
aditya(dot)toshniwal(at)enterprisedb(dot)com> wrote:

> Hi Akshay,
>
> The patch looks good to me.
>

Thanks patch applied.

>
> On Tue, Jan 29, 2019 at 4:54 PM Dave Page <dpage(at)pgadmin(dot)org> wrote:
>
>> Aditya, can you review this please? Once you're happy, Akshay can commit.
>>
>> On Tue, Jan 29, 2019 at 9:35 AM Akshay Joshi <
>> akshay(dot)joshi(at)enterprisedb(dot)com> wrote:
>>
>>> Hi Hackers,
>>>
>>> Attached is the patch to fix RM 3697 Detached Data Output Tab (Windows)
>>> does not show Select output. Please review it.
>>>
>>> --
>>> *Akshay Joshi*
>>>
>>> *Sr. Software Architect *
>>>
>>>
>>>
>>> *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
>>>
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>
>
> --
> Thanks and Regards,
> Aditya Toshniwal
> Software Engineer | EnterpriseDB Software Solutions | Pune
> "Don't Complain about Heat, Plant a tree"
>

--
*Akshay Joshi*

*Sr. Software Architect *

*Phone: +91 20-3058-9517Mobile: +91 976-788-8246*

In response to

Browse pgadmin-hackers by date

  From Date Subject
Next Message Aditya Toshniwal 2019-01-29 13:36:12 Re: [pgAdmin4][RM3936] Feature tests failing intermittently for SQL editor related test cases
Previous Message Akshay Joshi 2019-01-29 13:18:30 pgAdmin 4 commit: Ensure that output of the query should be displayed e