Re: [pgAdmin4][Patch]: RM #3619 Unable to Re-Dock Query Tool Lower Window Component

Hi Hackers,
On Tue, Nov 27, 2018 at 5:27 PM Dave Page <dpage(at)pgadmin(dot)org> wrote:

> Hi
> On Tue, Nov 27, 2018 at 11:48 AM Akshay Joshi <
> akshay(dot)joshi(at)enterprisedb(dot)com> wrote:
>
>> Hi Dave
>> On Tue, Nov 27, 2018 at 4:34 PM Dave Page <dpage(at)pgadmin(dot)org> wrote:
>>
>>> Hi
>>>
>>> On Tue, Nov 27, 2018 at 10:13 AM Akshay Joshi
>>> <akshay(dot)joshi(at)enterprisedb(dot)com> wrote:
>>> >
>>> > Hi Hackers,
>>> >
>>> > Attached is the patch to fix RM #3619 Unable to Re-Dock Query Tool
>>> Lower Window Component. Please review it.
>>>
>>> With this applied, I cannot move or resize floating windows.
>>>
>>
>> Attached is the modified patch. Please review it.
>>
>
> That's better, but I am still able to un-dock the last panel, despite it
> looking like it tries to prevent me. See the attached movie.
>

We have figured out the actual cause of the problem, there is no title
for the "SQL Editor" panel so when we undock lower window component then
there is no title bar present to re-dock it. To fix the issue we have added
the title for the "SQL Editor" panel and also move up the Query History
tab.

Attached is the patch, please review it.

>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>

--
*Akshay Joshi*

*Sr. Software Architect *

*Phone: +91 20-3058-9517Mobile: +91 976-788-8246*