| From: | Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com> |
|---|---|
| To: | Yogesh Mahajan <yogesh(dot)mahajan(at)enterprisedb(dot)com> |
| Cc: | Khushboo Vashi <khushboo(dot)vashi(at)enterprisedb(dot)com>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
| Subject: | Re: [pgAdmin4][Patch]: Fixed default public IP range issue in AWS deployment |
| Date: | 2022-03-11 04:41:32 |
| Message-ID: | CANxoLDf_ZfeECUA1XQcAJOPHs1E7eWC7=bThdAbGdqxxTotK2w@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
Hi Khushboo
Why there are two identical functions (def get_my_ip) in two different
files, can you please make it generic in one place only and send the patch.
On Fri, Mar 11, 2022 at 9:22 AM Yogesh Mahajan <
yogesh(dot)mahajan(at)enterprisedb(dot)com> wrote:
> Hi,
>
> Patch looks fine. IP Addresses are prefixed by 32 and 128 for IPv4 and
> IPv6 respectively.
>
> Thanks,
> Yogesh Mahajan
> EnterpriseDB
>
>
> On Fri, Mar 11, 2022 at 8:49 AM Khushboo Vashi <
> khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:
>
>> Hi,
>>
>> Please find the attached patch to fix the default Public IP range issue
>> in AWS deployment.
>>
>> @Yogesh Mahajan <yogesh(dot)mahajan(at)enterprisedb(dot)com>, please test.
>>
>>
>> Thanks,
>> Khushboo
>>
>
--
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Principal Software Architect*
*EDB Postgres <http://edbpostgres.com>*
*Mobile: +91 976-788-8246*
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Khushboo Vashi | 2022-03-11 06:26:25 | Re: [pgAdmin4][Patch]: Fixed default public IP range issue in AWS deployment |
| Previous Message | Yogesh Mahajan | 2022-03-11 03:51:24 | Re: [pgAdmin4][Patch]: Fixed default public IP range issue in AWS deployment |