| From: | Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com> |
|---|---|
| To: | Dave Page <dpage(at)pgadmin(dot)org> |
| Cc: | pgadmin-hackers <pgadmin-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Cleanup runtime qmake code |
| Date: | 2020-05-04 09:02:52 |
| Message-ID: | CANxoLDfYo-=tf9R-+OcCmbgvhnO98BD+K5BN2rgRVuEMv4cfwQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
Hi Dave
Patch looks good to me except one small change in the README file that is
PGADMIN_PYTHON_PATH is mentioned but it should be PGADMIN_PYTHON_DIR
On Fri, May 1, 2020 at 8:29 PM Dave Page <dpage(at)pgadmin(dot)org> wrote:
> The attached patch tidies up the qmake code for configuring the runtime
> build so that it's consistent on all platforms, and simply requires that
> the PGADMIN_PYTHON_DIR environment variable points to the Python
> installation to be used.
>
> Please review, but don't commit, as this change will probably break some
> of the Jenkins jobs. I'll commit and fix them when the patch has passed
> review.
>
> (Sidenote: this is part of a larger tidy up/standardisation of the build
> scripts).
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
--
*Thanks & Regards*
*Akshay Joshi*
*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dave Page | 2020-05-04 09:20:53 | pgAdmin 4 commit: Cleanup Python detection in the runtime project file. |
| Previous Message | Dave Page | 2020-05-04 08:25:08 | pgAdmin 4 commit: Correct ipv4 "all interfaces" address in the containe |