Re: [pgAdmin][RM6398]: Detaching query editor panel gives a blank white panel.

From: Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
To: Pradip Parkale <pradip(dot)parkale(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin][RM6398]: Detaching query editor panel gives a blank white panel.
Date: 2021-06-25 06:09:56
Message-ID: CANxoLDfVQFCZxhDGP22gpRNj6euYO+MZaZRujaxQJi+bWL97mQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Thanks, the patch applied.

On Thu, Jun 24, 2021 at 9:16 PM Pradip Parkale <
pradip(dot)parkale(at)enterprisedb(dot)com> wrote:

> Hi Akshay,
> Please find the updated patch. I have moved the function into the utility
> file now.
>
> On Thu, Jun 24, 2021 at 7:56 PM Akshay Joshi <
> akshay(dot)joshi(at)enterprisedb(dot)com> wrote:
>
>> Hi Pradip
>>
>> I have seen that we have duplicated code for resize_the_queryTool,
>> resize_the_erdtool, resize_the_psql, and in debugger_ui.js file. I would
>> suggest making a common function somewhere in the utils and call that
>> function. In the future, if we need to change the code we will have to
>> change it in four different places.
>>
>> Please resend the patch after fixing the above issue.
>>
>> On Thu, Jun 24, 2021 at 7:00 PM Pradip Parkale <
>> pradip(dot)parkale(at)enterprisedb(dot)com> wrote:
>>
>>> Hi Akshay,
>>>
>>> Please find attached for debugger and ERD tool which was missing in
>>> my previous patch.
>>>
>>> On Wed, Jun 23, 2021 at 11:50 AM Akshay Joshi <
>>> akshay(dot)joshi(at)enterprisedb(dot)com> wrote:
>>>
>>>> Thanks, the patch applied.
>>>>
>>>> On Wed, Jun 16, 2021 at 11:29 PM Pradip Parkale <
>>>> pradip(dot)parkale(at)enterprisedb(dot)com> wrote:
>>>>
>>>>> Hi Hackers,
>>>>>
>>>>> Please find the attached patch for #6398.Detaching query editor panel
>>>>> gives a blank white panel.
>>>>>
>>>>>
>>>>> --
>>>>> Thanks & Regards,
>>>>> Pradip Parkale
>>>>> Software Engineer | EnterpriseDB Corporation
>>>>>
>>>>
>>>>
>>>> --
>>>> *Thanks & Regards*
>>>> *Akshay Joshi*
>>>> *pgAdmin Hacker | Principal Software Architect*
>>>> *EDB Postgres <http://edbpostgres.com>*
>>>>
>>>> *Mobile: +91 976-788-8246*
>>>>
>>>
>>>
>>> --
>>> Thanks & Regards,
>>> Pradip Parkale
>>> Software Engineer | EnterpriseDB Corporation
>>>
>>
>>
>> --
>> *Thanks & Regards*
>> *Akshay Joshi*
>> *pgAdmin Hacker | Principal Software Architect*
>> *EDB Postgres <http://edbpostgres.com>*
>>
>> *Mobile: +91 976-788-8246*
>>
>
>
> --
> Thanks & Regards,
> Pradip Parkale
> Software Engineer | EnterpriseDB Corporation
>

--
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Principal Software Architect*
*EDB Postgres <http://edbpostgres.com>*

*Mobile: +91 976-788-8246*

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Pradip Parkale 2021-06-25 11:41:34 [pgAdmin][RM6557]: Incorrect column name listed in Properties of Index
Previous Message Akshay Joshi 2021-06-25 06:09:43 Re: [pgAdmin][RM6231]- Add OS, Browser details in pgAdmin About us pop-up