Re: [pgAdmin][RM4348] Theme options in pgAdmin and dark theme

Thanks, patch applied.

On Wed, Nov 20, 2019 at 11:59 AM Aditya Toshniwal <
aditya(dot)toshniwal(at)enterprisedb(dot)com> wrote:

> Hi Hackers,
>
> pgadmin.themes.json is created in web/pgadmin/misc/themes on "yarn run
> bundle" and is copied to generated directory also. This file is required
> for themes to show up.
> Currently, pgadmin.themes.json file is referred
> from web/pgadmin/misc/themes directory by the app. It is better to refer
> from generated directory instead so that it is not missed in the pgAdmin
> distribution phase. The pgAdmin 4.15 wheel distro is not having this file
> in web/pgadmin/misc/themes directory and so themes are not available in it.
> Attached is the patch to fix this.
>
>
> On Wed, Nov 13, 2019 at 11:36 AM Akshay Joshi <
> akshay(dot)joshi(at)enterprisedb(dot)com> wrote:
>
>> Thanks, patch applied.
>>
>> On Wed, Nov 13, 2019 at 10:46 AM Aditya Toshniwal <
>> aditya(dot)toshniwal(at)enterprisedb(dot)com> wrote:
>>
>>> Hi Hackers,
>>>
>>> Attached is the patch to set browser autofill color. I've used primary
>>> light color to highlight autofill. Note that, this works only on webkit
>>> browsers.
>>> Kindly review.
>>>
>>> On Wed, Nov 13, 2019 at 10:03 AM Aditya Toshniwal <
>>> aditya(dot)toshniwal(at)enterprisedb(dot)com> wrote:
>>>
>>>> Hi Dave,
>>>>
>>>> On Tue, Nov 12, 2019 at 7:29 PM Dave Page <dpage(at)pgadmin(dot)org> wrote:
>>>>
>>>>>
>>>>>
>>>>> On Tue, Nov 12, 2019 at 1:47 PM Aditya Toshniwal <
>>>>> aditya(dot)toshniwal(at)enterprisedb(dot)com> wrote:
>>>>>
>>>>>> Hi Hackers,
>>>>>>
>>>>>> Attached is the patch to customize the scrollbar styling. A new SASS
>>>>>> variable added - $scrollbar-base-color is added to change the color as per
>>>>>> theme.
>>>>>> Please note, customization of scrollbar works only in webkit browsers
>>>>>> like Chrome, Safari. Mozilla does not have any way to customize.
>>>>>>
>>>>>
>>>>> That looks much nicer :-).
>>>>>
>>>>> One more issue I just spotted - I'm guessing it's specific to Alertify
>>>>> dialogues:
>>>>>
>>>>> [image: Screenshot 2019-11-12 at 13.57.34.png]
>>>>>
>>>> This is your browser autofill which is changing the color and not the
>>>> issue with the dialogs.
>>>>
>>>>>
>>>>>
>>>>> --
>>>>> Dave Page
>>>>> Blog: http://pgsnake.blogspot.com
>>>>> Twitter: @pgsnake
>>>>>
>>>>> EnterpriseDB UK: http://www.enterprisedb.com
>>>>> The Enterprise PostgreSQL Company
>>>>>
>>>>
>>>>
>>>> --
>>>> Thanks and Regards,
>>>> Aditya Toshniwal
>>>> Sr. Software Engineer | EnterpriseDB India | Pune
>>>> "Don't Complain about Heat, Plant a TREE"
>>>>
>>>
>>>
>>> --
>>> Thanks and Regards,
>>> Aditya Toshniwal
>>> Sr. Software Engineer | EnterpriseDB India | Pune
>>> "Don't Complain about Heat, Plant a TREE"
>>>
>>
>>
>> --
>> *Thanks & Regards*
>> *Akshay Joshi*
>>
>> *Sr. Software Architect*
>> *EnterpriseDB Software India Private Limited*
>> *Mobile: +91 976-788-8246*
>>
>
>
> --
> Thanks and Regards,
> Aditya Toshniwal
> Sr. Software Engineer | EnterpriseDB India | Pune
> "Don't Complain about Heat, Plant a TREE"
>

--
*Thanks & Regards*
*Akshay Joshi*

*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*