Re: [pgAdmin][SonarQube] Reduce cognitive complexity

From: Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
To: Aditya Toshniwal <aditya(dot)toshniwal(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin][SonarQube] Reduce cognitive complexity
Date: 2020-09-02 12:00:49
Message-ID: CANxoLDfOyPEb1djO0c9JUVfkjHDL1NHJ1s-KQnF4QrHLZE5aMQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Thanks, patch applied.

On Tue, Sep 1, 2020 at 3:34 PM Aditya Toshniwal <
aditya(dot)toshniwal(at)enterprisedb(dot)com> wrote:

> Hi Hackers,
>
> Attached patch reduces cognitive complexity as below:
>
> web/.../server_groups/servers/pgagent/__init__.py - 23 to 15
> web/pgadmin/utils/driver/psycopg2/__init__.py - 23 to 15, 17 to 15
> web/setup.py 77 to 15
>
> Please review.
>
> --
> Thanks,
> Aditya Toshniwal
> pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com*
> <http://edbpostgres.com>
> "Don't Complain about Heat, Plant a TREE"
>

--
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Sr. Software Architect*
*EDB Postgres <http://edbpostgres.com>*

*Mobile: +91 976-788-8246*

In response to

Browse pgadmin-hackers by date

  From Date Subject
Next Message Warren Chan 2020-09-03 02:59:31 Re: pgAdmin4 - help adding new node to Browser Tree
Previous Message Akshay Joshi 2020-09-02 12:00:20 pgAdmin 4 commit: Added exclamation icon to alertify warning messages.