Re: [pgAdmin][RM4279] : Issue with File Browser Home button

Hi Yogesh

Tested on MAC OSX in both the mode (server, desktop) it is showing "/".
Please reverify it.

On Mon, Apr 27, 2020 at 10:58 AM Yogesh Jain <yogesh(dot)jain(at)enterprisedb(dot)com>
wrote:

> Hi Hackers,
>
> I have tested this patch in linux (Ubuntu 18.04) env only , which is
> working fine. It will be great if someone can review/test in the Windows
> environment as well as I don't have the setup ready for that.
>
> On Mon, Apr 27, 2020 at 10:47 AM Yogesh Jain <yogesh(dot)jain(at)enterprisedb(dot)com>
> wrote:
>
>> Hi Aditya,
>>
>> Thanks for the feedback. Here is an updated patch, regarding the same.
>>
>> Please Review.
>> PFA.
>>
>> On Mon, Apr 27, 2020 at 9:05 AM Aditya Toshniwal <
>> aditya(dot)toshniwal(at)enterprisedb(dot)com> wrote:
>>
>>> Hi Yogesh,
>>>
>>> Just did an eyeball review. You've included homedir path in the response
>>> rendered JS file. You're exposing underlying directory structure to users
>>> even in server mode. This is not appropriate. This info should remain at
>>> the server and not at the client side.
>>> + homedir=os.path.expanduser('~'),
>>>
>>> On Fri, Apr 24, 2020 at 7:26 PM Yogesh Jain <
>>> yogesh(dot)jain(at)enterprisedb(dot)com> wrote:
>>>
>>>> Hi Hackers,
>>>>
>>>> Attached is the patch to fix the issue with the file browser Home
>>>> button.
>>>>
>>>> FYI : While clicking on the home button it was pointing to the user's
>>>> root directory rather than home directory, which is fixed in this patch.
>>>>
>>>> Please review.
>>>> PFA.
>>>>
>>>> --
>>>> Regards,
>>>> Yogesh Jain
>>>> 8982696654
>>>>
>>>
>>>
>>> --
>>> Thanks and Regards,
>>> Aditya Toshniwal
>>> pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
>>> "Don't Complain about Heat, Plant a TREE"
>>>
>>
>>
>> --
>> Regards,
>> Yogesh Jain
>> 8982696654
>>
>
>
> --
> Regards,
> Yogesh Jain
> 8982696654
>

--
*Thanks & Regards*
*Akshay Joshi*

*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*