Re: [pgAdmin][RM-6143]: Shared server entries not getting deleted.

From: Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
To: Dave Page <dpage(at)pgadmin(dot)org>
Cc: Nikhil Mohite <nikhil(dot)mohite(at)enterprisedb(dot)com>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin][RM-6143]: Shared server entries not getting deleted.
Date: 2021-01-21 09:54:18
Message-ID: CANxoLDfN2AehHnBPDLPO1vR+yw-16T8dcRx04--UX-69UmCzqQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Reverted the commit.

On Thu, Jan 21, 2021 at 3:13 PM Dave Page <dpage(at)pgadmin(dot)org> wrote:

> This seems like a very bad idea. What if the user that has left was the
> user that setup 50 connections used by everyone else?
>
> Deleting those shared entries is (I would guess) most likely *not* what
> the majority of users would want, and the current behaviour is definitely
> safest.
>
> We should make this optional; i.e. ask the use if they want shared servers
> created by the user to be deleted. If they say no, they should be
> reassigned to another user; either the admin that's deleting the user, or
> their choice of user (a little more complex of course, but more flexible).
>
> Please revert this, until the deletion is made optional.
>
> On Thu, Jan 21, 2021 at 9:23 AM Akshay Joshi <
> akshay(dot)joshi(at)enterprisedb(dot)com> wrote:
>
>> Thanks, patch applied.
>>
>> On Thu, Jan 21, 2021 at 12:18 PM Nikhil Mohite <
>> nikhil(dot)mohite(at)enterprisedb(dot)com> wrote:
>>
>>> Hi Team,
>>>
>>> Please find the attached patch for RM-6143
>>> <https://redmine.postgresql.org/issues/6143>: Shared server entries not
>>> getting deleted.
>>> Added code to delete shared server entries if the admin deletes the user
>>> from user management.
>>>
>>>
>>> --
>>> *Thanks & Regards,*
>>> *Nikhil Mohite*
>>> *Software Engineer.*
>>> *EDB Postgres* <https://www.enterprisedb.com/>
>>> *Mob.No: +91-7798364578.*
>>>
>>
>>
>> --
>> *Thanks & Regards*
>> *Akshay Joshi*
>> *pgAdmin Hacker | Principal Software Architect*
>> *EDB Postgres <http://edbpostgres.com>*
>>
>> *Mobile: +91 976-788-8246*
>>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EDB: http://www.enterprisedb.com
>
>

--
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Principal Software Architect*
*EDB Postgres <http://edbpostgres.com>*

*Mobile: +91 976-788-8246*

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Khushboo Vashi 2021-01-21 10:16:44 Re: [pgAmin4][Patch] - Kerberos support for Windows Installer
Previous Message Akshay Joshi 2021-01-21 09:53:17 pgAdmin 4 commit: Revert "Fixed an issue where shared server entries no