| From: | Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com> |
|---|---|
| To: | Harshal Dhumal <harshal(dot)dhumal(at)enterprisedb(dot)com> |
| Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
| Subject: | Re: [pgAdmin4] [RM3862] Fix Dialog tabset keyboard navigation |
| Date: | 2019-01-21 11:09:32 |
| Message-ID: | CANxoLDfEG1Vzxb=YtXbUkRfj43WO=CAaUhdtPy-mP91eDKNuCg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
Hi Khushboo
Can you please review it.
On Wed, Jan 16, 2019 at 12:55 PM Harshal Dhumal <
harshal(dot)dhumal(at)enterprisedb(dot)com> wrote:
> Hi,
>
> Please find attached updated patch.
> In this patch I have fixed two issues:
> i. Dialog tab navigation should work even if focus is on footer buttons
> (Save, Cancel, etc..)
> ii. Focus should be set to first editable element of dialog when tab cycle
> goes through all editable footer buttons.
>
>
> --
> *Harshal Dhumal*
> *Sr. Software Engineer*
>
> EnterpriseDB India: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>
> On Thu, Jan 10, 2019 at 1:16 PM Harshal Dhumal <
> harshal(dot)dhumal(at)enterprisedb(dot)com> wrote:
>
>> Hi,
>> This patch fixes Dialog tabset keyboard navigation.
>> This regression was caused due to bootstrap 4 changes.
>> Also I have added jasmine test cases for the same
>>
>>
>> --
>> *Harshal Dhumal*
>> *Sr. Software Engineer*
>>
>> EnterpriseDB India: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>
--
*Akshay Joshi*
*Sr. Software Architect *
*Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Akshay Joshi | 2019-01-21 11:09:49 | Re: [pgAdmin4][RM3908] backgrid navigation fix for Select2Cell and PrivilegeCell |
| Previous Message | Aditya Toshniwal | 2019-01-21 11:03:26 | [pgAdmin4][RM3871] Alignment issue with IE Browser |