Re: [pgadmin4][Patch]: Feature #3273 Add ability to sort in the Select File window when opening a saved query

On Thu, Jun 21, 2018 at 11:57 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:

> Hi
>
> On Thu, Jun 21, 2018 at 6:27 AM, Akshay Joshi <
> akshay(dot)joshi(at)enterprisedb(dot)com> wrote:
>
>>
>>
>> On Thu, Jun 21, 2018 at 6:20 AM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>>
>>> Hi
>>>
>>> On Wed, Jun 20, 2018 at 3:13 PM, Akshay Joshi <
>>> akshay(dot)joshi(at)enterprisedb(dot)com> wrote:
>>>
>>>> Hi Hackers,
>>>>
>>>> Attached is the patch for Feature #3273 Add ability to sort in the
>>>> Select File window when opening a saved query.
>>>>
>>>> I haven't seen any refactoring possibility, patch contains feature test
>>>> with *time.sleep(0.05). *I have spend lot of time to not introduce
>>>> "time.sleep()" and tried couple of different ways of WebDriveWait, but
>>>> didn't get success.
>>>>
>>>> Please review it.
>>>>
>>>
>>> I get the following running the feature tests:
>>>
>>> invalid syntax (xss_checks_file_manager_test.py, line 60)
>>>
>>> make: *** [check-feature] Error 1
>>>
>>> Fixed.
>>
>>
>>> Also; should that file be renamed now, to reflect that it tests more
>>> than just XSS?
>>>
>>
>> Done. Attached is the modified patch.
>>
>
> This seems to work for the most part, however, when sorting on the
> Modified column, it is sorting alphabetically, not by date. This doesn't
> seem like it's what users would expect.
>

Attached is the modified patch with the above fix.

>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>

--
*Akshay Joshi*

*Sr. Software Architect *

*Phone: +91 20-3058-9517Mobile: +91 976-788-8246*