From: | Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com> |
---|---|
To: | Nikhil Mohite <nikhil(dot)mohite(at)enterprisedb(dot)com>, Aradhana Birewar <aradhana(dot)birewar(at)enterprisedb(dot)com> |
Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: [pgAdmin][RM5653]: High Contrast UI Theme |
Date: | 2020-07-17 08:06:07 |
Message-ID: | CANxoLDf9hTpEGm-MiNuswieScLGedG+W-TOcc5kp9Ub7DPSHKQ@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Hi Nikhil
Found two more issues:
- Focus is not visible when we hover on the close button of any dialog.
- Schema Diff tool fixes refer the below screenshot
[image: Screenshot 2020-07-17 at 1.29.53 PM.png]
On Fri, Jul 17, 2020 at 1:06 PM Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
wrote:
> Hi Nikhil
>
> I have applied the patch and run the pgAdmin in High Contrast Theme.
> Following issues, I have found
>
> - Add *(Beta) *suffix in "High Contrast" in the preferences dialog.
> - Update the documentation for High Contrast Theme in Preferences.
> - Three different colors used for dialog header (Properties, Grant
> Wizard, Maintenance). Refer the below screenshot
>
> [image: Dialog Border Color.png]
>
> @Aradhana Birewar <aradhana(dot)birewar(at)enterprisedb(dot)com> Can we use the same
> light blue color for the properties, grant wizard, and maintenance dialog?
>
> - In the Query History tab, SQL is not readable. Refer the below
> screenshot
>
> [image: Query_History.png]
>
> Aditya is doing the code review so wait for his review comments and then
> send the combined patch.
>
>
> On Fri, Jul 17, 2020 at 12:25 PM Akshay Joshi <
> akshay(dot)joshi(at)enterprisedb(dot)com> wrote:
>
>> Aditya, can you please do the code review.
>>
>> On Thu, Jul 16, 2020 at 6:54 PM Nikhil Mohite <
>> nikhil(dot)mohite(at)enterprisedb(dot)com> wrote:
>>
>>> Hi Team,
>>>
>>> I have completed changes for the support of the new High-Contrast UI
>>> Theme RM-#5653 <https://redmine.postgresql.org/issues/5653>.
>>>
>>> PFA patch.
>>>
>>>
>>> Regards,
>>> Nikhil Mohite.
>>>
>>>
>>
>> --
>> *Thanks & Regards*
>> *Akshay Joshi*
>>
>> *Sr. Software Architect*
>> *EnterpriseDB Software India Private Limited*
>> *Mobile: +91 976-788-8246*
>>
>
>
> --
> *Thanks & Regards*
> *Akshay Joshi*
>
> *Sr. Software Architect*
> *EnterpriseDB Software India Private Limited*
> *Mobile: +91 976-788-8246*
>
--
*Thanks & Regards*
*Akshay Joshi*
*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*
From | Date | Subject | |
---|---|---|---|
Next Message | Aradhana Birewar | 2020-07-17 08:17:48 | Re: [pgAdmin][RM5653]: High Contrast UI Theme |
Previous Message | Akshay Joshi | 2020-07-17 07:36:40 | Re: [pgAdmin][RM5653]: High Contrast UI Theme |