Re: [pgAdmin][RM7350] More query tool fixes

From: Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
To: Aditya Toshniwal <aditya(dot)toshniwal(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin][RM7350] More query tool fixes
Date: 2022-05-09 09:41:39
Message-ID: CANxoLDf6E4n2C2GgEEhk7cLEV3xWST6g81zXQqtiJFqNUsrLBg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Thanks, the patch applied.

On Mon, May 9, 2022 at 2:37 PM Aditya Toshniwal <
aditya(dot)toshniwal(at)enterprisedb(dot)com> wrote:

> Hi,
>
> Attached patch upgrades react-data-grid to latest fork which has fix for
> grid issues.
>
> On Mon, May 9, 2022 at 12:46 PM Akshay Joshi <
> akshay(dot)joshi(at)enterprisedb(dot)com> wrote:
>
>> Thanks, the patch applied.
>>
>> On Mon, May 9, 2022 at 11:51 AM Aditya Toshniwal <
>> aditya(dot)toshniwal(at)enterprisedb(dot)com> wrote:
>>
>>> Hi Hackers,
>>>
>>> Since this is not committed yet. Adding a few more fixes. Patch fixes:
>>> 1. Warning/Confirm dialogs should be inside the query tool.
>>> 2. The Help button in View/Edit data should open the corresponding help
>>> page.
>>> 3. Disable execute options when query tool in transaction.
>>> 4. Grid not loading more than 10000 rows. react-data-grid issue, PR
>>> sent. Use a fork till then.
>>> 5. NOTICE messages should not be part of Notifier success popups.
>>>
>>> Please review.
>>>
>>> On Fri, May 6, 2022 at 2:39 PM Aditya Toshniwal <
>>> aditya(dot)toshniwal(at)enterprisedb(dot)com> wrote:
>>>
>>>> Hi Hackers,
>>>>
>>>> Please ignore the previous patch. Added one more fix. Patch fixes:
>>>> 1. Warning/Confirm dialogs should be inside the query tool.
>>>> 2. The Help button in View/Edit data should open the corresponding help
>>>> page.
>>>> 3. Disable execute options when query tool in transaction.
>>>>
>>>> On Fri, May 6, 2022 at 9:58 AM Aditya Toshniwal <
>>>> aditya(dot)toshniwal(at)enterprisedb(dot)com> wrote:
>>>>
>>>>> Hi Hackers,
>>>>>
>>>>> Attached patch fixes:
>>>>> 1. Warning/Confirm dialogs should be inside the query tool.
>>>>> 2. The Help button in View/Edit data should open the corresponding
>>>>> help page.
>>>>> Please review.
>>>>>
>>>>> --
>>>>> Thanks,
>>>>> Aditya Toshniwal
>>>>> pgAdmin Hacker | Software Architect | *edbpostgres.com*
>>>>> <http://edbpostgres.com>
>>>>> "Don't Complain about Heat, Plant a TREE"
>>>>>
>>>>
>>>>
>>>> --
>>>> Thanks,
>>>> Aditya Toshniwal
>>>> pgAdmin Hacker | Software Architect | *edbpostgres.com*
>>>> <http://edbpostgres.com>
>>>> "Don't Complain about Heat, Plant a TREE"
>>>>
>>>
>>>
>>> --
>>> Thanks,
>>> Aditya Toshniwal
>>> pgAdmin Hacker | Software Architect | *edbpostgres.com*
>>> <http://edbpostgres.com>
>>> "Don't Complain about Heat, Plant a TREE"
>>>
>>
>>
>> --
>> *Thanks & Regards*
>> *Akshay Joshi*
>> *pgAdmin Hacker | Principal Software Architect*
>> *EDB Postgres <http://edbpostgres.com>*
>>
>> *Mobile: +91 976-788-8246*
>>
>
>
> --
> Thanks,
> Aditya Toshniwal
> pgAdmin Hacker | Software Architect | *edbpostgres.com*
> <http://edbpostgres.com>
> "Don't Complain about Heat, Plant a TREE"
>

--
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Principal Software Architect*
*EDB Postgres <http://edbpostgres.com>*

*Mobile: +91 976-788-8246*

In response to

Browse pgadmin-hackers by date

  From Date Subject
Next Message Akshay Joshi 2022-05-09 11:24:00 pgAdmin4 v6.9 candidate builds
Previous Message Akshay Joshi 2022-05-09 09:41:23 pgAdmin 4 commit: Upgrades react-data-grid to the latest which has a fi