Re: RM 4463 - RESQL test cases for domain node

From: Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
To: Neel Patel <neel(dot)patel(at)enterprisedb(dot)com>
Cc: Dave Page <dpage(at)pgadmin(dot)org>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: RM 4463 - RESQL test cases for domain node
Date: 2019-08-21 11:24:40
Message-ID: CANxoLDf66mQREt-bdWm2=w_a1cDjG10=FykE90SPnc=t7p=yng@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi Neel

MSQL test case for *create* was not running before. In my last patch I have
fixed that. Applying your patch on latest code not working can you please
fix that and re-send the patch.

On Wed, Aug 21, 2019 at 2:33 PM Neel Patel <neel(dot)patel(at)enterprisedb(dot)com>
wrote:

> Hi,
>
> Please find attached patch that will add more resql test cases for domain
> node.
>
> - Covered test cases for Length, Precision and Collation.
> - Also added msql test cases.
>
> While writing resql test cases for domain node, I found one more issue
> RM-4644 <https://redmine.postgresql.org/issues/4644>. I am sending
> separate patch for the same.
>
> Thanks,
> Neel Patel
>
> On Fri, Jul 12, 2019 at 7:10 PM Dave Page <dpage(at)pgadmin(dot)org> wrote:
>
>> Thanks, applied.
>>
>> On Fri, Jul 12, 2019 at 12:31 PM Neel Patel <neel(dot)patel(at)enterprisedb(dot)com>
>> wrote:
>>
>>> Hi,
>>>
>>> Please find attached patch for reverse engineering test cases for domain
>>> node ( RM #4463 )
>>> Do review it and let me know for comments.
>>>
>>> Thanks,
>>> Neel Patel
>>>
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>

--
*Thanks & Regards*
*Akshay Joshi*

*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*

In response to

Browse pgadmin-hackers by date

  From Date Subject
Next Message Akshay Joshi 2019-08-21 12:42:46 pgAdmin 4 commit: Move schema precondition logic into separate function
Previous Message Akshay Joshi 2019-08-21 10:57:51 Re: [Patch]: RM-4644 - Length and Precision control for domain node