Re: [PATCH] [RM# 3290] Close button missing for the message window from the backend server

From: Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
To: Dave Page <dpage(at)pgadmin(dot)org>
Cc: Anthony Emengo <aemengo(at)pivotal(dot)io>, Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] [RM# 3290] Close button missing for the message window from the backend server
Date: 2018-04-24 08:59:12
Message-ID: CANxoLDezCbK1Ucg=+EXBUTrTanweb8n4cuPvjQLsL3eei=JxbQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

On Tue, Apr 24, 2018 at 1:47 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:

> Akshay, can you review/commit this please?
>

Sure.

>
> Thanks.
>
> On Mon, Apr 23, 2018 at 3:34 PM, Anthony Emengo <aemengo(at)pivotal(dot)io>
> wrote:
>
>> Just manually verified that this worked, and the patch successfully went
>> through our pipelines.
>>
>> Thanks so much for fixing this issue!
>>
>> - Joao and Anthony
>>
>> On Mon, Apr 23, 2018 at 3:40 AM, Ashesh Vashi <
>> ashesh(dot)vashi(at)enterprisedb(dot)com> wrote:
>>
>>> Hi Team,
>>>
>>> Please find the patch for fixing the RM #3290.
>>> The 'Close button' was missing in the message box, which shows the error
>>> in the backend server.
>>>
>>> This patch also fixes some of the missing keycode 'ESCAPE' on 'Cancel'
>>> buttons in different modules.
>>>
>>> Please review.
>>>
>>> --
>>>
>>> Thanks & Regards,
>>>
>>> Ashesh Vashi
>>> EnterpriseDB INDIA: Enterprise PostgreSQL Company
>>> <http://www.enterprisedb.com>
>>>
>>>
>>> *http://www.linkedin.com/in/asheshvashi*
>>> <http://www.linkedin.com/in/asheshvashi>
>>>
>>
>>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>

--
*Akshay Joshi*

*Sr. Software Architect *

*Phone: +91 20-3058-9517Mobile: +91 976-788-8246*

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Akshay Joshi 2018-04-24 08:59:38 Re: [pgadmin4][patch] [GreenPlum] Display SQL of table with index #3306
Previous Message Akshay Joshi 2018-04-24 08:58:30 Re: [pgAdmin4][RM#3155] Allow user to lock the Layout