| From: | Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com> |
|---|---|
| To: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
| Subject: | [pgAdmin4][Patch]: RM #4110 "Updating 'Custom auto-vacuum?' property throws error for Materialized View." |
| Date: | 2019-03-28 13:15:33 |
| Message-ID: | CANxoLDevJiSFrRQMdAoA36QPs7OGFz=hS=F7=YhzBXPabBuiEg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
Hi Hackers,
I have started working on RM #4110 "Updating 'Custom auto-vacuum?' property
throws error for Materialized View." and while working I have figured out
following issues:
- Reset some/all the parameter for table and toast table is not
implemented.
- Value of "Custom auto-vacuum?" is not retrieved and set properly.
- When user set the "Custom auto-vacuum?" to "Yes" and none of the
parameter is set previously then set the value of "Enabled?" control to
"Yes".
- Alignment of Table and remove extra margin from "Parameters" tab.
Attached is the patch to fix all the above issues. Added API test cases.
Please review it.
--
*Thanks & Regards*
*Akshay Joshi*
*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*
| Attachment | Content-Type | Size |
|---|---|---|
| RM_4110.patch | application/octet-stream | 48.8 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Khushboo Vashi | 2019-03-28 13:18:12 | [pgAdmin4][Patch] - RM 4082 - Download CSV error displayed for procedure and functions with create script |
| Previous Message | Dave Page | 2019-03-28 12:36:47 | pgAdmin 4 commit: Include inherited column comments and defaults in rev |