Re: Patch for SonarQube code scan fixes

From: Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
To: Nikhil Mohite <nikhil(dot)mohite(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: Patch for SonarQube code scan fixes
Date: 2020-07-14 10:35:33
Message-ID: CANxoLDeqU7QCcAbmRetNdAZ5KsfmM=iHx_d5ypMJeXiLpeRa-A@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Thanks, patch applied. I have changed the function name from "def
_get_reverse_engineered_sql_for_<node name>" to "def _get_resql_for_<node
name>", because function name is too long.

On Mon, Jul 13, 2020 at 9:40 AM Nikhil Mohite <
nikhil(dot)mohite(at)enterprisedb(dot)com> wrote:

> Hi Team,
>
> I have fixed some code smell issues in the SonarQube scan, PFA patch.
> Details as follows:
> 1. Table file(utils):
>
> - Refactor this function to reduce its Cognitive Complexity from 39 to
> the 15 allowed.
> - Refactor this function to reduce its Cognitive Complexity from 122
> to the 15 allowed.
> - Refactor this function to reduce its Cognitive Complexity from 58 to
> the 15 allowed.
>
> 2. Table init file:
>
> - Refactor this function to reduce its Cognitive Complexity from 24 to
> the 15 allowed.
> - Refactor this function to reduce its Cognitive Complexity from 22 to
> the 15 allowed.
> - Refactor this function to reduce its Cognitive Complexity from 18 to
> the 15 allowed.
>
>
>
> Regards,
> Nikhil Mohite.
>

--
*Thanks & Regards*
*Akshay Joshi*

*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*

In response to

Browse pgadmin-hackers by date

  From Date Subject
Next Message Akshay Joshi 2020-07-14 10:35:53 Re: Re-[pgAdmin][RM-5323]
Previous Message Akshay Joshi 2020-07-14 10:28:36 pgAdmin 4 commit: Improve code coverage and API test cases for Foreign