| From: | Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com> |
|---|---|
| To: | Khushboo Vashi <khushboo(dot)vashi(at)enterprisedb(dot)com> |
| Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
| Subject: | Re: [pgAdmin4][Patch]: Fixed RMs #1220 & #1221 |
| Date: | 2018-05-02 12:26:16 |
| Message-ID: | CANxoLDensKKYfFRGmcVOOEf+KNFhXK0yK1vPJ177=o4OZSTEEA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
Hi Khushboo
I have reviewed your code and looks good to me. Can we change the message
from "The database name is inappropriate" to some meaningful message, so
that user should know why it is inappropriate. If user will be able to
create database with "=" in name then why Backup, Maintenance and Restore
fails.
On Wed, May 2, 2018 at 3:44 PM, Khushboo Vashi <
khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:
> Hi,
>
> Please find the attached patch which will fix RMs # 1220 and #1221.
>
> If the database name contains = then the backup, maintenance and restore
> jobs are failing.
> To fix these, we will display the error message regarding inappropriate
> database name.
>
> Thanks,
> Khushboo
>
--
*Akshay Joshi*
*Sr. Software Architect *
*Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ashesh Vashi | 2018-05-02 12:33:59 | Re: [pgAdmin4][Patch]: Fixed RMs #1220 & #1221 |
| Previous Message | Dave Page | 2018-05-02 11:05:21 | pgAdmin 4 commit: Python 3 fixes |