Re: Runtime refactoring

Hi Dave/Hackers,

Attached is the patch to fix newly introduce SoanrQube code smells. Please
review it.

On Tue, Jul 28, 2020 at 4:22 PM Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
wrote:

> Thanks, patch applied with some fixes. I'll work on the SonarQube code
> smell and commit them later.
>
> On Mon, Jul 27, 2020 at 5:55 PM Dave Page <dpage(at)pgadmin(dot)org> wrote:
>
>> Hi Akshay,
>>
>> Updated patch attached.
>>
>> Thanks.
>>
>> On Mon, Jul 27, 2020 at 12:08 PM Akshay Joshi <
>> akshay(dot)joshi(at)enterprisedb(dot)com> wrote:
>>
>>> Hi Dave
>>>
>>> The patch is not applied, can you please rebase and send again.
>>>
>>> On Fri, Jul 17, 2020 at 3:40 PM Dave Page <dpage(at)pgadmin(dot)org> wrote:
>>>
>>>> BTW, this will fix https://redmine.postgresql.org/issues/5490
>>>>
>>>> On Thu, Jul 16, 2020 at 10:41 AM Dave Page <dpage(at)pgadmin(dot)org> wrote:
>>>>
>>>>> Here's a pretty large patch that implements a major refactoring of the
>>>>> runtime code. Specifically:
>>>>>
>>>>> - Move the bulk of the core code from main() into a new Runtime class.
>>>>> - Break up the mass of code that was main() into a number of
>>>>> relatively simple functions.
>>>>> - Make the Configuration dialog synchronous so the Log dialog can be
>>>>> properly viewed.
>>>>> - Enable/disable menu options at the right time.
>>>>> - Remove support for Qt < 5.0.
>>>>> - Remove the application name constant and hardcode the name to
>>>>> simplify the code.
>>>>> - Improve log messages.
>>>>> - Replace the sdbm hashing with Qt's MD5 hashing.
>>>>>
>>>>> Please review & test, but do not commit before next week's release.
>>>>>
>>>>> Thanks!
>>>>>
>>>>> --
>>>>> Dave Page
>>>>> Blog: http://pgsnake.blogspot.com
>>>>> Twitter: @pgsnake
>>>>>
>>>>> EDB: http://www.enterprisedb.com
>>>>>
>>>>>
>>>>
>>>> --
>>>> Dave Page
>>>> Blog: http://pgsnake.blogspot.com
>>>> Twitter: @pgsnake
>>>>
>>>> EDB: http://www.enterprisedb.com
>>>>
>>>>
>>>
>>> --
>>> *Thanks & Regards*
>>> *Akshay Joshi*
>>> *pgAdmin Hacker | Sr. Software Architect*
>>> *EDB Postgres <http://edbpostgres.com>*
>>>
>>> *Mobile: +91 976-788-8246*
>>>
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EDB: http://www.enterprisedb.com
>>
>>
>
> --
> *Thanks & Regards*
> *Akshay Joshi*
> *pgAdmin Hacker | Sr. Software Architect*
> *EDB Postgres <http://edbpostgres.com>*
>
> *Mobile: +91 976-788-8246*
>

--
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Sr. Software Architect*
*EDB Postgres <http://edbpostgres.com>*

*Mobile: +91 976-788-8246*