Re: [pgAdmin][RM6581] [React] Port Language node to react

Thanks, the patch applied.

On Thu, Jul 15, 2021 at 3:50 PM Pradip Parkale <
pradip(dot)parkale(at)enterprisedb(dot)com> wrote:

> Hi Akshay,
>
> Please find the updated patch.
>
> On Fri, Jul 9, 2021 at 5:13 PM Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
> wrote:
>
>> Hi Pradip
>>
>> Following are the review comments:
>>
>> - The language name is not visible for the existing language in the
>> properties panel as well as dialog.
>>
>> Fixed.
>
>>
>> - The "Trusted?" switch is showing the wrong value for the 'plpgsql'
>> language in the properties panel as well as dialog.
>>
>> Fixed.
>
>>
>> - Unable to provide custom language names as we did before this patch.
>>
>> Fixed.
>
>>
>> - All the controls on the "Definition" tab are always disabled, also
>> values are not getting populated for existing language.
>>
>> Fixed.
>
>>
>> - Improve the code coverage to 80%, currently, it is 72.13%
>>
>> Fixed, improved to 78%.
>
>>
>> On Thu, Jul 8, 2021 at 7:22 PM Pradip Parkale <
>> pradip(dot)parkale(at)enterprisedb(dot)com> wrote:
>>
>>> Hi Hackers,
>>>
>>> Please find the attached patch for #6581: [React] Port Language node to
>>> react
>>>
>>> --
>>> Thanks & Regards,
>>> Pradip Parkale
>>> Software Engineer | EnterpriseDB Corporation
>>>
>>
>>
>> --
>> *Thanks & Regards*
>> *Akshay Joshi*
>> *pgAdmin Hacker | Principal Software Architect*
>> *EDB Postgres <http://edbpostgres.com>*
>>
>> *Mobile: +91 976-788-8246*
>>
>
>
> --
> Thanks & Regards,
> Pradip Parkale
> Software Engineer | EnterpriseDB Corporation
>

--
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Principal Software Architect*
*EDB Postgres <http://edbpostgres.com>*

*Mobile: +91 976-788-8246*