Re: [pgAdmin4][RM#4142] Add the recommended ESLinter checks again.

From: Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
To: Murtuza Zabuawala <murtuza(dot)zabuawala(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin4][RM#4142] Add the recommended ESLinter checks again.
Date: 2019-04-05 07:38:29
Message-ID: CANxoLDeiTX=tTPyj_f62W3OhNVVeiUbvmiHZa-mF58_pVRc0KQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Thanks patch applied.

On Fri, Apr 5, 2019 at 11:49 AM Murtuza Zabuawala <
murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:

> Hi,
>
> Issue: We removed recommended ESLinter checking with RM#4019 commit.
>
> If you see now ESLint is no longer complaining about many issues which are
> listed here https://eslint.org/docs/rules/ and marked as [✓].
> Simple test case is to add debugger; statement in JS code and run linter,
> we can see that linter is not complaining about it, earlier it was.
>
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>

--
*Thanks & Regards*
*Akshay Joshi*

*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*

In response to

Browse pgadmin-hackers by date

  From Date Subject
Next Message Murtuza Zabuawala 2019-04-05 10:18:17 [pgAdmin4][RM#4138] Allow us to set the dropdown body when rendering Select2 control
Previous Message Akshay Joshi 2019-04-05 07:38:06 pgAdmin 4 commit: Added recommended ESLinter checks. Fixes #4142