Re: [pgAdmin4][Patch] - SonarQube Issues - 6 (A conditionally executed single line should be denoted by indentation, A "while" loop should be used instead of a "for" loop)

From: Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
To: Yogesh Mahajan <yogesh(dot)mahajan(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin4][Patch] - SonarQube Issues - 6 (A conditionally executed single line should be denoted by indentation, A "while" loop should be used instead of a "for" loop)
Date: 2020-06-26 08:13:51
Message-ID: CANxoLDei-TfxfkFLeLvcJwzNr1=YiQ5NyVnhTJC=DXmzjCYUtA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Thanks, patch applied.

On Thu, Jun 25, 2020 at 5:05 PM Yogesh Mahajan <
yogesh(dot)mahajan(at)enterprisedb(dot)com> wrote:

> Hi,
>
> Please find patch fixing the issues related to below rules -
> 1.A conditionally executed single line should be denoted by indentation,
> 2.A "while" loop should be used instead of a "for" loop.
>
> Thanks,
> Yogesh Mahajan
> QA - Team
> EnterpriseDB Corporation
>
> Phone: +91-9741705709
>
>
> On Thu, Jun 25, 2020 at 12:28 PM Akshay Joshi <
> akshay(dot)joshi(at)enterprisedb(dot)com> wrote:
>
>> Hi Yogesh
>>
>> Please fix the linter error and send the patch again.
>>
>> On Thu, Jun 25, 2020 at 12:26 PM Yogesh Mahajan <
>> yogesh(dot)mahajan(at)enterprisedb(dot)com> wrote:
>>
>>> Hi,
>>>
>>> Please find patch fixing the issues related to below rules -
>>> 1.A conditionally executed single line should be denoted by indentation,
>>> 2.A "while" loop should be used instead of a "for" loop, \
>>> 3.Variables should be declared explicitly)
>>>
>>> Thanks,
>>> Yogesh Mahajan
>>> QA - Team
>>> EnterpriseDB Corporation
>>>
>>> Phone: +91-9741705709
>>>
>>
>>
>> --
>> *Thanks & Regards*
>> *Akshay Joshi*
>>
>> *Sr. Software Architect*
>> *EnterpriseDB Software India Private Limited*
>> *Mobile: +91 976-788-8246*
>>
>

--
*Thanks & Regards*
*Akshay Joshi*

*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*

In response to

Browse pgadmin-hackers by date

  From Date Subject
Next Message Akshay Joshi 2020-06-26 08:14:00 Re: [pgAdmin4][Patch] SonarQube Fixes
Previous Message Akshay Joshi 2020-06-26 08:13:31 Re: [pgAdmin4][Patch] - SonarQube Issues - 5 (Rule Boolean checks should not be inverted, Comma operator should not be used)