Re: pgAdmin 4 - next gettext usage fixes

Thanks, patch applied.

On Wed, Apr 15, 2020 at 2:55 PM Aditya Toshniwal <
aditya(dot)toshniwal(at)enterprisedb(dot)com> wrote:

> Hi,
>
> Please find the updated patch.
>
> On Wed, Apr 15, 2020 at 1:33 PM Akshay Joshi <
> akshay(dot)joshi(at)enterprisedb(dot)com> wrote:
>
>> Hi Aditya
>>
>> I think the fix is incorrect. .format method should be applied after
>> gettext() like gettext().format(). Please check for other places too and
>> send the updated patch.
>>
>> On Wed, Apr 15, 2020 at 11:38 AM Aditya Toshniwal <
>> aditya(dot)toshniwal(at)enterprisedb(dot)com> wrote:
>>
>>> Hi Hackers/Libor,
>>>
>>> The changes like below are incorrect. Try "Count rows" from a table's
>>> context menu.
>>>
>>> - info=gettext("Table rows counted: %s" % count),
>>>
>>> + info=gettext("Table rows counted: %s") % count,
>>>
>>> Attached is the patch to fix all such changes in pgAdmin, to use
>>> format() instead.
>>> Please review.
>>>
>>> On Fri, Apr 10, 2020 at 2:57 PM Akshay Joshi <
>>> akshay(dot)joshi(at)enterprisedb(dot)com> wrote:
>>>
>>>> Hi Libor
>>>>
>>>> Thanks, patch applied. Please make sure to run the PEP8 checks before
>>>> sending the patch.
>>>> I have fixed and committed the code.
>>>>
>>>> On Wed, Apr 8, 2020 at 9:30 PM Libor M. <liborm85(at)gmail(dot)com> wrote:
>>>>
>>>>> Hello,
>>>>> I fixed next gettext usage:
>>>>>
>>>>> - fixed gettext usage with .format() only for original text with %s
>>>>> - fixed typos
>>>>> - fixed translation yes/no buttons in dialog
>>>>> - improved translating sentences without "connecting" words (eg. see
>>>>> web/pgadmin/dashboard/static/js/dashboard.js, word 'cancel' needs to
>>>>> be translated in Czech language as 'zrušit' but in another sentence as
>>>>> 'zrušení')
>>>>> - added gettext for text translations
>>>>>
>>>>> Diff file is attached.
>>>>>
>>>>> Best regards,
>>>>>
>>>>> Libor M.
>>>>>
>>>>> E-mail: liborm85(at)gmail(dot)com
>>>>> GitHub: https://github.com/liborm85
>>>>>
>>>>
>>>>
>>>> --
>>>> *Thanks & Regards*
>>>> *Akshay Joshi*
>>>>
>>>> *Sr. Software Architect*
>>>> *EnterpriseDB Software India Private Limited*
>>>> *Mobile: +91 976-788-8246*
>>>>
>>>
>>>
>>> --
>>> Thanks and Regards,
>>> Aditya Toshniwal
>>> pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
>>> "Don't Complain about Heat, Plant a TREE"
>>>
>>
>>
>> --
>> *Thanks & Regards*
>> *Akshay Joshi*
>>
>> *Sr. Software Architect*
>> *EnterpriseDB Software India Private Limited*
>> *Mobile: +91 976-788-8246*
>>
>
>
> --
> Thanks and Regards,
> Aditya Toshniwal
> pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
> "Don't Complain about Heat, Plant a TREE"
>

--
*Thanks & Regards*
*Akshay Joshi*

*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*