Re: [pgAdmin][patch] browser beforeunload event code improvements

From: Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
To: Aditya Toshniwal <aditya(dot)toshniwal(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin][patch] browser beforeunload event code improvements
Date: 2019-04-22 06:01:51
Message-ID: CANxoLDeY6+JbQfWePnRn1dnBzfVzNjTsQ9oovCkCm0ZNYxenyA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Thanks patch applied.

On Fri, Apr 19, 2019 at 5:58 PM Aditya Toshniwal <
aditya(dot)toshniwal(at)enterprisedb(dot)com> wrote:

> Hi Hackers,
>
> Attached is the patch as an improvement for before unload event setting.
> Changes are done to bind event beforeunload only where required, unlike
> previously where just loading browser.js would bind the events which might
> kill its reusability.
>
> Kindly review.
>
> --
> Thanks and Regards,
> Aditya Toshniwal
> Software Engineer | EnterpriseDB Software Solutions | Pune
> "Don't Complain about Heat, Plant a tree"
>

--
*Thanks & Regards*
*Akshay Joshi*

*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*

In response to

Browse pgadmin-hackers by date

  From Date Subject
Next Message Khushboo Vashi 2019-04-22 06:18:13 [pgAdmin4][Patch] - RM 4087 - Default sequence privileges does not show update grant
Previous Message Akshay Joshi 2019-04-22 06:01:23 pgAdmin 4 commit: Improvement for 'beforeunload' event, bind the event