| From: | Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com> |
|---|---|
| To: | Yogesh Mahajan <yogesh(dot)mahajan(at)enterprisedb(dot)com> |
| Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
| Subject: | Re: [pgAdmin4][Patch] - SonarQube Issues - 5 (Rule Boolean checks should not be inverted, Comma operator should not be used) |
| Date: | 2020-06-24 07:01:25 |
| Message-ID: | CANxoLDeGRFyv8gGnVd6F-To+X41VzJ4Jq=oo3zpYf43rYnCUUA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
Hi Yogesh
After applying your patch a new sonarqube issue has been found "Change this
argument to the documented type: Number." in sqleditor_utils.js
Please fix that and resend the patch.
On Mon, Jun 22, 2020 at 4:36 PM Yogesh Mahajan <
yogesh(dot)mahajan(at)enterprisedb(dot)com> wrote:
> Hi Hackers,
>
> Please find patch fixing sonarqube issues related to below rules -
>
> 1.Boolean checks should not be inverted,
> 2.Comma operator should not be used,
> 3.Arguments to built-in functions should match documented types,
> 4.Redundant pairs of parentheses should be removed,
>
> Thanks,
> Yogesh Mahajan
> QA - Team
> EnterpriseDB Corporation
>
> Phone: +91-9741705709
>
--
*Thanks & Regards*
*Akshay Joshi*
*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Satish V | 2020-06-24 07:47:56 | Reg-[pgAdmin4][Patch] - SonarQube - Extra semicolons should be removed and Method names should comply with a naming convention |
| Previous Message | Rahul Shirsat | 2020-06-23 19:10:57 | [pgAdmin][RM3851] Add proper indentation to the code when generating a stored procedure |