Re: [pgadmin-support] Support for non standard SSH port

From: Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
To: Dave Page <dpage(at)pgadmin(dot)org>
Cc: Alex Grechko <alex(dot)grechko(at)rambler(dot)ru>, Pgadmin Support <pgadmin-support(at)postgresql(dot)org>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgadmin-support] Support for non standard SSH port
Date: 2013-11-18 13:16:48
Message-ID: CANxoLDeFCwhoyrPs-eaEcUw1HKuGUjLJ3f7tHR2SE4vf60wJoQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers pgadmin-support

On Mon, Nov 18, 2013 at 5:50 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:

>
>
>
> On Mon, Nov 18, 2013 at 12:00 PM, Akshay Joshi <
> akshay(dot)joshi(at)enterprisedb(dot)com> wrote:
>
>>
>>
>>
>> On Mon, Nov 18, 2013 at 5:24 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>>
>>> Hi
>>>
>>>
>>> On Mon, Nov 18, 2013 at 11:06 AM, Akshay Joshi <
>>> akshay(dot)joshi(at)enterprisedb(dot)com> wrote:
>>>
>>>> Hi Dave
>>>>
>>>> I have added support for non standard remote SSH port. I have added one
>>>> control to take input for "Default SSH port" from the user in SSH Tunnel
>>>> tab, by default it is 22, but user can modify it.
>>>>
>>>> Attached is the patch file, can you please review it. If it looks good
>>>> to you can you please commit it.
>>>>
>>>
>>> Shouldn't it just be "SSH Port"?
>>>
>> OR "Remote SSH Port"?
>>
>
> "Tunnel Port" seems like it would fit in with the existing UI a little
> better.
>

Done. Attached is the new modified patch.

>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>

--
*Akshay Joshi*
*Principal Software Engineer *

*Phone: +91 20-3058-9517Mobile: +91 976-788-8246*

Attachment Content-Type Size
SSHTunnel_Non_Default_Port_v2.patch application/octet-stream 12.5 KB

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Dave Page 2013-11-19 09:08:17 Re: PATCH: Choose best width for Data Output columns of Query tool
Previous Message Dave Page 2013-11-18 12:20:30 Re: Support for non standard SSH port

Browse pgadmin-support by date

  From Date Subject
Next Message Deven Thaker 2013-11-18 16:06:26 getting NaN in the table
Previous Message Dave Page 2013-11-18 12:20:30 Re: Support for non standard SSH port