Re: [pgAdmin][SonarQube] : Remove duplicates string literals.

Thanks, patch applied.

On Thu, Sep 3, 2020 at 7:19 PM Pradip Parkale <
pradip(dot)parkale(at)enterprisedb(dot)com> wrote:

> Hi Akshay,
>
> Please find the updated patch.
>
>
> On Thu, Sep 3, 2020 at 6:24 PM Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
> wrote:
>
>> Hi Pradip
>>
>> Following are the review comments:
>>
>> - ROLE_NOT_FOUND already in wrapped in gettext() then no need to use
>> like gone(_(ROLE_NOT_FOUND)). In fact, can we use
>>
>> self.not_found_error_msg()instead of new constant.
>>
>> - Same with ERROR_FETCHING_ROLE_INFORMATION it's already in gettext,
>> also we can use this constant for string "
>>
>> Error retrieving roles from the database server"
>>
>>
>>
>> On Thu, Sep 3, 2020 at 4:30 PM Pradip Parkale <
>> pradip(dot)parkale(at)enterprisedb(dot)com> wrote:
>>
>>> Hi Hackers,
>>>
>>> Attached is a patch for removing duplicates string literals.
>>> /server_groups/servers/roles/__init__.py - 8 places
>>>
>>>
>>>
>>> --
>>> Thanks & Regards,
>>> Pradip Parkale
>>> Software Engineer | EnterpriseDB Corporation
>>>
>>
>>
>> --
>> *Thanks & Regards*
>> *Akshay Joshi*
>> *pgAdmin Hacker | Sr. Software Architect*
>> *EDB Postgres <http://edbpostgres.com>*
>>
>> *Mobile: +91 976-788-8246*
>>
>
>
> --
> Thanks & Regards,
> Pradip Parkale
> Software Engineer | EnterpriseDB Corporation
>

--
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Sr. Software Architect*
*EDB Postgres <http://edbpostgres.com>*

*Mobile: +91 976-788-8246*