Re: [pgAdmin4][Patch]: RM 2089 - PARALLEL SAFE support for functions missing

Hi Dave

I have reviewed the patch and after applying it output in pgAdmin4

CREATE OR REPLACE FUNCTION public.st_intersects(geom1 geometry, geom2
geometry)
RETURNS boolean
LANGUAGE 'sql'
COST 100.0
*IMMUTABLE NOT LEAKPROOF *
* PARALLEL SAFE*
AS $function$
SELECT $1 OPERATOR(public.&&) $2 AND public._ST_Intersects($1,$2)
$function$;

but as per psql it should be

CREATE OR REPLACE FUNCTION public.st_intersects(geom1 geometry, geom2
geometry)

RETURNS boolean

LANGUAGE sql

*IMMUTABLE PARALLEL SAFE*

AS $function$SELECT $1 OPERATOR(public.&&) $2 AND
public._ST_Intersects($1,$2)$function$

is this behaviour correct??

On Fri, Feb 3, 2017 at 5:31 PM, Khushboo Vashi <
khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:

> Hi,
>
> Please find the attached patch to fix RM 2089 : PARALLEL SAFE support for
> functions missing.
>
> Fix: Incorporated the PARALLEL SAFE support for the functions and
> procedures for PostgreSQL 9.6.
>
> Thanks,
> Khushboo
>
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>
>

--
*Akshay Joshi*
*Principal Software Engineer *

*Phone: +91 20-3058-9517Mobile: +91 976-788-8246*