Re: [pgAdmin4][Patch]: RM 3284 - F5 key not working consistently

Thanks patch applied.

On Wed, May 2, 2018 at 11:16 AM, Khushboo Vashi <
khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:

> Hi Akshay,
>
> Please find the attached patch which fixes the linter issues.
>
> Thanks,
> Khushboo
>
> On Wed, May 2, 2018 at 11:10 AM, Akshay Joshi <
> akshay(dot)joshi(at)enterprisedb(dot)com> wrote:
>
>> Hi Joao
>>
>> Linter fails for 'parse_shortcut_value_spec.js' file:
>>
>> $ node pga_eslint.js
>>
>>
>> /Users/akshay/Development/pgadmin4/web/regression/javascript
>> /parse_shortcut_value_spec.js
>>
>> 13:4 error Expected indentation of 2 spaces but found 3 indent
>>
>> 14:7 error Expected indentation of 5 spaces but found 6 indent
>>
>> 21:26 error Missing trailing comma
>> comma-dangle
>>
>> 22:12 error Missing trailing comma
>> comma-dangle
>>
>> 26:4 error Expected indentation of 2 spaces but found 3 indent
>>
>> 27:7 error Expected indentation of 5 spaces but found 6 indent
>>
>> 34:26 error Missing trailing comma
>> comma-dangle
>>
>> 35:12 error Missing trailing comma
>> comma-dangle
>>
>> 39:4 error Expected indentation of 2 spaces but found 3 indent
>>
>> 40:7 error Expected indentation of 5 spaces but found 6 indent
>>
>> 47:25 error Missing trailing comma
>> comma-dangle
>>
>> 48:12 error Missing trailing comma
>> comma-dangle
>>
>> 52:4 error Expected indentation of 2 spaces but found 3 indent
>>
>> 53:7 error Expected indentation of 5 spaces but found 6 indent
>>
>> 60:25 error Missing trailing comma
>> comma-dangle
>>
>> 61:12 error Missing trailing comma
>> comma-dangle
>>
>> 65:4 error Expected indentation of 2 spaces but found 3 indent
>>
>> 66:7 error Expected indentation of 5 spaces but found 6 indent
>>
>> 73:25 error Missing trailing comma
>> comma-dangle
>>
>> 74:12 error Missing trailing comma
>> comma-dangle
>>
>> 78:4 error Expected indentation of 2 spaces but found 3 indent
>>
>> 79:7 error Expected indentation of 5 spaces but found 6 indent
>>
>> 86:25 error Missing trailing comma
>> comma-dangle
>>
>> 87:12 error Missing trailing comma
>> comma-dangle
>>
>> 91:4 error Expected indentation of 2 spaces but found 3 indent
>>
>> 92:7 error Expected indentation of 5 spaces but found 6 indent
>>
>> 99:25 error Missing trailing comma
>> comma-dangle
>>
>> 100:12 error Missing trailing comma
>> comma-dangle
>>
>> 104:4 error Expected indentation of 2 spaces but found 3 indent
>>
>> 105:7 error Expected indentation of 5 spaces but found 6 indent
>>
>> 112:25 error Missing trailing comma
>> comma-dangle
>>
>> 113:12 error Missing trailing comma
>> comma-dangle
>>
>>
>> *✖ 32 problems (32 errors, 0 warnings)*
>>
>>
>>
>>
>> On Mon, Apr 30, 2018 at 8:10 PM, Joao De Almeida Pereira <
>> jdealmeidapereira(at)pivotal(dot)io> wrote:
>>
>>> Hi there,
>>>
>>> We weren't able to see these functions get called. Perhaps we're missing
>>> something.
>>>
>>> Thanks,
>>> Joao && Anthony
>>>
>>> On Mon, Apr 30, 2018 at 2:48 AM Khushboo Vashi <
>>> khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:
>>>
>>>> Hi Joao,
>>>>
>>>> The patches look good however I have noticed that you
>>>> deleted attachShortcut and attachDialogTabNavigatorShortcut functions
>>>> from keyboard.js, any specific reason for that?
>>>>
>>>> Thanks,
>>>> Khushboo
>>>>
>>>> On Fri, Apr 27, 2018 at 3:11 AM, Joao De Almeida Pereira <
>>>> jdealmeidapereira(at)pivotal(dot)io> wrote:
>>>>
>>>>> Hi Khushboo,
>>>>>
>>>>> I did some changes on your patch:
>>>>> 0001 - Your original patch
>>>>> 0002 - Convert keyboard.js to ES6
>>>>> 0003 - Refactoring of the keyboard.js file(some one letter variables
>>>>> and other code)
>>>>>
>>>>>
>>>>>
>>>>> Thanks
>>>>> Joao
>>>>>
>>>>> On Thu, Apr 26, 2018 at 5:34 AM Khushboo Vashi <
>>>>> khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:
>>>>>
>>>>>> Hi,
>>>>>>
>>>>>> Please find the attached patch to fix the RM #3284 : F5 key not
>>>>>> working consistently.
>>>>>>
>>>>>> - Added the configurable keyboard shortcut (default F5) to refresh
>>>>>> the browser tree nodes.
>>>>>>
>>>>>>
>>>>>> Thanks,
>>>>>> Khushboo
>>>>>>
>>>>>
>>>>
>>
>>
>> --
>> *Akshay Joshi*
>>
>> *Sr. Software Architect *
>>
>>
>>
>> *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
>>
>
>

--
*Akshay Joshi*

*Sr. Software Architect *

*Phone: +91 20-3058-9517Mobile: +91 976-788-8246*