Re: [pgAdmin][SonarQube] Cognitive complexity

Thanks, patch applied.

On Tue, Aug 25, 2020 at 12:32 PM Aditya Toshniwal <
aditya(dot)toshniwal(at)enterprisedb(dot)com> wrote:

> Hi Akshay,
>
> Attached is the updated patch.
>
> On Tue, Aug 25, 2020 at 11:38 AM Akshay Joshi <
> akshay(dot)joshi(at)enterprisedb(dot)com> wrote:
>
>> Hi Aditya
>>
>> Please fix the following issues:
>>
>> - Add docstrings to the newly created functions.
>> - Fix PEP8 issue.
>>
>>
>>
>> On Mon, Aug 24, 2020 at 5:02 PM Aditya Toshniwal <
>> aditya(dot)toshniwal(at)enterprisedb(dot)com> wrote:
>>
>>> Hi Hackers,
>>>
>>> Attached patch reduces the cognitive complexity of functions for below:
>>> web/.../schemas/packages/edbfuncs/__init__.py 21 to 15
>>> web/.../databases/schemas/types/__init__.py 39 to 15; 80 to 15
>>> web/.../server_groups/servers/pgagent/__init__.py 39 to 15
>>> web/pgadmin/misc/bgprocess/process_executor.py 19 to 15
>>> web/pgadmin/tools/backup/__init__.py 54 to 15
>>>
>>> Please review.
>>>
>>> --
>>> Thanks,
>>> Aditya Toshniwal
>>> pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com*
>>> <http://edbpostgres.com>
>>> "Don't Complain about Heat, Plant a TREE"
>>>
>>
>>
>> --
>> *Thanks & Regards*
>> *Akshay Joshi*
>> *pgAdmin Hacker | Sr. Software Architect*
>> *EDB Postgres <http://edbpostgres.com>*
>>
>> *Mobile: +91 976-788-8246*
>>
>
>
> --
> Thanks,
> Aditya Toshniwal
> pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com*
> <http://edbpostgres.com>
> "Don't Complain about Heat, Plant a TREE"
>

--
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Sr. Software Architect*
*EDB Postgres <http://edbpostgres.com>*

*Mobile: +91 976-788-8246*