Fixed compilation issue on some Operating System

From: Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
To: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Fixed compilation issue on some Operating System
Date: 2013-05-16 09:04:27
Message-ID: CANxoLDe5QSBBLzQEYTH7gBaXbvFmoakc+R=nVfE4sTjKBm7i2Q@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi Dave

Some of us are facing compilation issue on some operating system due to the
inclusion of SSH Tunnel code. I have tried a lot to figure it out, but not
found the exact cause of the problem.

Thanks to "Tim Wood" from salesforce for finding the cause of the problem.
The problem is order of libssh2 dependent libraries is not correct in
linker command.

Resolution for the issue is to add the libssh2 dependent libraries in LIBS
flags instead of LDFLAGS, because LDFLAGS were added ahead of the pgadmin3
objects and LIBS are added after, so because of that linker is able to find
all the references from the dependent libraries.

Attached is the patch file to fix the issue. Please review it and if it
looks good to you can you please commit it.

--
*Akshay Joshi
Senior Software Engineer
EnterpriseDB Corporation
The Enterprise PostgreSQL Company
Phone: +91 20-3058-9522
Mobile: +91 976-788-8246*

Attachment Content-Type Size
Fixed_Compilation_issue.patch application/octet-stream 925 bytes

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Dave Page 2013-05-16 10:37:28 pgAdmin III commit: Fix linker error seen on some Linux distros (e.g. S
Previous Message Dave Page 2013-05-15 15:57:21 Remove dialogue "Apply" buttons?