Re: [pgAdmin4] [Patch]: Resource Group Module

Hi All

Attached is the patch with the fixes. Please review it and if looks good
then please commit it.

On Mon, Feb 8, 2016 at 11:54 AM, Neel Patel <neel(dot)patel(at)enterprisedb(dot)com>
wrote:

> Hi Akshay,
>
> Please find below review comments.
>
> - As per the pgAdmin3, we should allow to enter the floating point value
> in "CPU Rate Limit" and "Dirty Rate Limit".
>
Fixed.

- While creating resource group, we are getting error saying
"*generate_browser_node()
> missing 1 required positional argument: 'label'*".
>
Fixed.

- Valid range for CPU Rate Limit and Dirty Rate Limit is from 0 to
> 1.67772e+07. We are not able to enter the maximum limit value while
> creating the
> resource group.
>

Partially fixed, I have limit the max length to 8 digits, but not able
to fixed it to the exact range.

>
> Thanks,
> Neel Patel
>
> On Fri, Feb 5, 2016 at 6:15 PM, Akshay Joshi <
> akshay(dot)joshi(at)enterprisedb(dot)com> wrote:
>
>> Hi All
>>
>> I have added logic to show sql in the "SQL" tab on dashboard and also
>> fixed some warnings. Please refer and review this patch.
>>
>> On Thu, Feb 4, 2016 at 5:50 PM, Akshay Joshi <
>> akshay(dot)joshi(at)enterprisedb(dot)com> wrote:
>>
>>> Hi All
>>>
>>> Attached is the patch for the Resource Group Module. Please review it
>>> and if it looks good then please commit it.
>>>
>>> --
>>> *Akshay Joshi*
>>> *Principal Software Engineer *
>>>
>>>
>>>
>>> *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
>>>
>>
>>
>>
>> --
>> *Akshay Joshi*
>> *Principal Software Engineer *
>>
>>
>>
>> *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
>>
>>
>> --
>> Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
>> To make changes to your subscription:
>> http://www.postgresql.org/mailpref/pgadmin-hackers
>>
>>
>

--
*Akshay Joshi*
*Principal Software Engineer *

*Phone: +91 20-3058-9517Mobile: +91 976-788-8246*