Re: Fix a bug of schema diff when comparing triggers with different when clauses

From: Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
To: "huangj(dot)fnst(at)fujitsu(dot)com" <huangj(dot)fnst(at)fujitsu(dot)com>
Cc: "pgadmin-hackers(at)postgresql(dot)org" <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: Fix a bug of schema diff when comparing triggers with different when clauses
Date: 2021-03-01 07:51:10
Message-ID: CANxoLDe1v9i1G45HnQOdWJGw83UE7AcN_LETqXcuwb4vvmy=fw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Thanks, patch applied.

On Mon, Mar 1, 2021 at 7:36 AM huangj(dot)fnst(at)fujitsu(dot)com <
huangj(dot)fnst(at)fujitsu(dot)com> wrote:

> Hi,
>
>
>
> When I compare triggers with different when clauses, it shows the wrong
> diff DDL.
>
>
>
> I tried to fix the bug , as the attached patch shows.
>
>
>
> --
>
> Thanks && regards
>
> HuangJ
>
>
>

--
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Principal Software Architect*
*EDB Postgres <http://edbpostgres.com>*

*Mobile: +91 976-788-8246*

In response to

Browse pgadmin-hackers by date

  From Date Subject
Next Message Nikhil Mohite 2021-03-01 10:42:18 [pgAdmin]: Patch for SonarQube fixes.
Previous Message Akshay Joshi 2021-03-01 07:50:50 pgAdmin 4 commit: Fixed an issue where schema diff showing wrong SQL wh