Re: [pgAdmin4][PATCH] To fix the add New Server through Quick links on Dashboard

From: Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
To: Murtuza Zabuawala <murtuza(dot)zabuawala(at)enterprisedb(dot)com>
Cc: Surinder Kumar <surinder(dot)kumar(at)enterprisedb(dot)com>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin4][PATCH] To fix the add New Server through Quick links on Dashboard
Date: 2017-08-17 12:54:26
Message-ID: CANxoLDe-spj330t3Khe3RzE9wAB80Nd9h2ZBM_2an1KFgnWNWA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Thanks patch applied.

On Tue, Aug 8, 2017 at 1:55 PM, Murtuza Zabuawala <
murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:

> Hi,
>
> PFA updated patch for the same.
>
> Thanks Surinder for pointing that out, I assumed that we had a typo in
> that file.
>
>
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
> [image: https://community.postgresrocks.net/]
> <https://community.postgresrocks.net/>
>
> On Tue, Aug 8, 2017 at 12:18 PM, Surinder Kumar <
> surinder(dot)kumar(at)enterprisedb(dot)com> wrote:
>
>> Hi Murtuza,
>>
>> As type server-group is renamed to server_group, I can see there are
>> other occurrences of string server-group which needs to be replaced when
>> I perform search in pgAdmin4.
>>
>> Can you please take care of those occurrences?
>>
>> Thanks,
>> Surinder
>>
>> On Tue, Aug 8, 2017 at 12:02 PM, Murtuza Zabuawala
>> [murtuza(dot)zabuawala(at)enterprisedb(dot)com](mailto:murtuza.
>> zabuawala(at)enterprisedb(dot)com)
>> <http://mailto:%5Bmurtuza(dot)zabuawala(at)enterprisedb(dot)com%5D(mailto:murtuza(dot)zabuawala(at)enterprisedb(dot)com)>
>> wrote:
>>
>> Hi,
>>>
>>> PFA minor patch to fix the issue where add new server functionality
>>> through Quick link on Dashboard is broken.
>>> RM#2634
>>>
>>> --
>>> Regards,
>>> Murtuza Zabuawala
>>> EnterpriseDB: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>> [image: https://community.postgresrocks.net/]
>>> <https://community.postgresrocks.net/>
>>>
>> ​
>>
>
>

--
*Akshay Joshi*
*Principal Software Engineer *

*Phone: +91 20-3058-9517Mobile: +91 976-788-8246*

In response to

Browse pgadmin-hackers by date

  From Date Subject
Next Message pgAdmin 4 Jenkins 2017-08-17 13:47:50 Build failed in Jenkins: pgadmin4-master-python36 #280
Previous Message Akshay Joshi 2017-08-17 12:54:10 pgAdmin 4 commit: User can not add New Server through Quick links. Fixe