| From: | Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com> |
|---|---|
| To: | Pradip Parkale <pradip(dot)parkale(at)enterprisedb(dot)com> |
| Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
| Subject: | Re: [pgAdmin][RM6581] [React] Port Language node to react |
| Date: | 2021-07-09 11:43:48 |
| Message-ID: | CANxoLDdz5nh8YbaE2qKJpdCueu3Lz13qgUtqhWHuRgLWnQ4WaA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
Hi Pradip
Following are the review comments:
- The language name is not visible for the existing language in the
properties panel as well as dialog.
- The "Trusted?" switch is showing the wrong value for the 'plpgsql'
language in the properties panel as well as dialog.
- Unable to provide custom language names as we did before this patch.
- All the controls on the "Definition" tab are always disabled, also
values are not getting populated for existing language.
- Improve the code coverage to 80%, currently, it is 72.13%
On Thu, Jul 8, 2021 at 7:22 PM Pradip Parkale <
pradip(dot)parkale(at)enterprisedb(dot)com> wrote:
> Hi Hackers,
>
> Please find the attached patch for #6581: [React] Port Language node to
> react
>
> --
> Thanks & Regards,
> Pradip Parkale
> Software Engineer | EnterpriseDB Corporation
>
--
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Principal Software Architect*
*EDB Postgres <http://edbpostgres.com>*
*Mobile: +91 976-788-8246*
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Khushboo Vashi | 2021-07-09 12:18:44 | [pgAdmin4][Patch] - RM #6594 - Unable to login with OAuth2 when LDAP & OAuth2 configured as login sources |
| Previous Message | Pradip Parkale | 2021-07-08 13:52:05 | [pgAdmin][RM6581] [React] Port Language node to react |