| From: | Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com> |
|---|---|
| To: | Aditya Toshniwal <aditya(dot)toshniwal(at)enterprisedb(dot)com> |
| Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>, "Libor M(dot)" <liborm85(at)gmail(dot)com> |
| Subject: | Re: pgAdmin 4 - gettext usage fixes |
| Date: | 2020-03-23 10:30:21 |
| Message-ID: | CANxoLDdxMRw_DZOjTrkTQwUau0VQ+wwMpezQkzAdUsZNeBJO2w@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
Hi Aditya
Can you please review this?
On Mon, Mar 23, 2020 at 5:00 AM Libor M. <liborm85(at)gmail(dot)com> wrote:
> Hello,
> I fixed using gettext function and add more usages for translations,
> specifically:
>
> - fixed usage gettext('') instead of _('') in javascript files
> - fixed usage gettext('') instead of `${gettext('')}` in javascript
> files, because "pybabel extract" not support extracting from this
> syntax
> - added a lot of gettext for support translations
>
> Diff file is attached.
>
> Best regards,
>
> Libor M.
>
> E-mail: liborm85(at)gmail(dot)com
> GitHub: https://github.com/liborm85
>
--
*Thanks & Regards*
*Akshay Joshi*
*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Aditya Toshniwal | 2020-03-23 12:16:12 | [pgAdmin][RM5128] [Accessibility] Revisit color contrast to meet the standards |
| Previous Message | Vijender Thakur | 2020-03-23 05:18:52 | Re: Want to contribute as a developer |