Re: [pgAdmin][RM5330]: [Code Coverage] Improve API test cases for Functions

From: Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
To: Nikhil Mohite <nikhil(dot)mohite(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin][RM5330]: [Code Coverage] Improve API test cases for Functions
Date: 2020-09-22 11:32:29
Message-ID: CANxoLDduK0isJUAwFkp84jthXn7R9Tb_-y2E_u5TNxRCTCVV-g@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Thanks, patch applied

On Tue, 22 Sep, 2020, 12:44 Nikhil Mohite, <nikhil(dot)mohite(at)enterprisedb(dot)com>
wrote:

> Hi Akshay/Team,
>
> I checked the code and found an issue in the "msql" function, due to which
> test cases were failing.
> I have fixed the issue, PFA updated patch for the same.
> Sorry for the inconvenience.
>
>
> Regards,
> Nikhil Mohite.
>
>
>
> On Tue, Sep 22, 2020 at 11:41 AM Akshay Joshi <
> akshay(dot)joshi(at)enterprisedb(dot)com> wrote:
>
>> Hi Nikhil
>>
>> Test cases are failing for all the database server with the following
>> error:
>> return True, sql.strip('\n')
>> AttributeError: 'tuple' object has no attribute 'strip'
>>
>> Please check and resend the patch.
>>
>> On Tue, Sep 22, 2020 at 10:56 AM Nikhil Mohite <
>> nikhil(dot)mohite(at)enterprisedb(dot)com> wrote:
>>
>>> Hi Team,
>>>
>>> I have added few more test cases for the "Functions" module as per
>>> RM-5330 <https://redmine.postgresql.org/issues/5330>
>>> PFA patch.
>>>
>>> --
>>> *Thanks & Regards,*
>>> *Nikhil Mohite*
>>> *Software Engineer.*
>>> *EDB Postgres* <https://www.enterprisedb.com/>
>>> *Mob.No: +91-7798364578.*
>>>
>>
>>
>> --
>> *Thanks & Regards*
>> *Akshay Joshi*
>> *pgAdmin Hacker | Sr. Software Architect*
>> *EDB Postgres <http://edbpostgres.com>*
>>
>> *Mobile: +91 976-788-8246*
>>
>

In response to

Browse pgadmin-hackers by date

  From Date Subject
Next Message Akshay Joshi 2020-09-22 11:33:09 Re: RM5841: server.username can be empty when using .pg_service.conf
Previous Message Akshay Joshi 2020-09-22 11:19:19 pgAdmin 4 commit: Improve code coverage and API test cases for Function