From: | Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com> |
---|---|
To: | Aditya Toshniwal <aditya(dot)toshniwal(at)enterprisedb(dot)com> |
Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: [pgAdmin][RM4101] No confirmation before window refresh in query tabs |
Date: | 2019-04-18 10:12:28 |
Message-ID: | CANxoLDdtr+7-xwPw12s8Scv73uFu8ddbSkTDOfykzbH-UsGp1w@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Thanks patch applied.
On Wed, Apr 17, 2019 at 3:58 PM Aditya Toshniwal <
aditya(dot)toshniwal(at)enterprisedb(dot)com> wrote:
> Hi Hackers,
>
> Attached is the patch to ask for confirmation before reload if query tool
> or debugger is opened in a new tab.
> I have also fixed a small issue where debugger is not opening in new tab.
>
> The datagrid/close URL which is called when query tool is closed was
> called with GET method, which is ethically incorrect. Made it to use DELETE
> instead.
>
> Kindly review.
>
> --
> Thanks and Regards,
> Aditya Toshniwal
> Software Engineer | EnterpriseDB Software Solutions | Pune
> "Don't Complain about Heat, Plant a tree"
>
--
*Thanks & Regards*
*Akshay Joshi*
*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*
From | Date | Subject | |
---|---|---|---|
Next Message | Dave Page | 2019-04-18 10:18:09 | pgAdmin 4 commit: Fix skip on Windows. |
Previous Message | Akshay Joshi | 2019-04-18 10:10:51 | pgAdmin 4 commit: Ensure that confirmation dialog should be popped up b |