Re: [pgAdmin][RM-5741]: [Schema Diff] Revisit all the CREATE and DROP DDL's to add appropriate 'IF EXISTS', 'CASCADE' and 'CREATE OR REPLACE'

Please rebase and send the patch.

On Tue, Sep 28, 2021 at 3:05 PM Nikhil Mohite <
nikhil(dot)mohite(at)enterprisedb(dot)com> wrote:

> Hi Akshay,
>
> Please find the updated patch for RM-5741.
>
> On Wed, Sep 22, 2021 at 7:17 PM Akshay Joshi <
> akshay(dot)joshi(at)enterprisedb(dot)com> wrote:
>
>> Thanks, the patch applied with some modifications. Changed the variable
>> names.
>>
>> On Wed, Sep 22, 2021 at 4:44 PM Nikhil Mohite <
>> nikhil(dot)mohite(at)enterprisedb(dot)com> wrote:
>>
>>> Hi Akshay,
>>>
>>> Please find the updated patch.
>>>
>>> On Mon, Sep 20, 2021 at 8:13 PM Akshay Joshi <
>>> akshay(dot)joshi(at)enterprisedb(dot)com> wrote:
>>>
>>>> Hi Nikhil
>>>>
>>>> As per the discussion, we need to create a flag for whether to add
>>>> the 'IF EXISTS" clause or not. Please send the combined patch after fixing
>>>> that for all the nodes.
>>>>
>>>> On Mon, Sep 20, 2021 at 3:58 PM Nikhil Mohite <
>>>> nikhil(dot)mohite(at)enterprisedb(dot)com> wrote:
>>>>
>>>>> Hi Akshay,
>>>>>
>>>>> Please find the patch for RM-5741.
>>>>> Updated missing sql checks for following nodes:
>>>>> 1. Role
>>>>> 2. Resources Group
>>>>> 3. Schema
>>>>> 4. Language
>>>>> 5. Tablespace
>>>>>
>>>>>
>>>>> Regards,
>>>>> Nikhil Mohite
>>>>>
>>>>> On Fri, Jul 30, 2021 at 1:23 PM Akshay Joshi <
>>>>> akshay(dot)joshi(at)enterprisedb(dot)com> wrote:
>>>>>
>>>>>> Thanks, the patch applied to the React_Porting branch as it is a big
>>>>>> change.
>>>>>> With the testing of each node after porting this patch also gets
>>>>>> tested.
>>>>>>
>>>>>> On Thu, Jul 29, 2021 at 8:34 PM Nikhil Mohite <
>>>>>> nikhil(dot)mohite(at)enterprisedb(dot)com> wrote:
>>>>>>
>>>>>>> Hi Hackers,
>>>>>>>
>>>>>>> Please find the attached patch for RM-5741
>>>>>>> <https://redmine.postgresql.org/issues/5741>: [Schema Diff] Revisit
>>>>>>> all the CREATE and DROP DDL's to add appropriate 'IF EXISTS', 'CASCADE' and
>>>>>>> 'CREATE OR REPLACE'
>>>>>>>
>>>>>>> Tested RESQL and API test cases on PG-9.6 to 13 and EPAS-9.6 to 13.3.
>>>>>>>
>>>>>>>
>>>>>>> --
>>>>>>> *Thanks & Regards,*
>>>>>>> *Nikhil Mohite*
>>>>>>> *Software Engineer.*
>>>>>>> *EDB Postgres* <https://www.enterprisedb.com/>
>>>>>>> *Mob.No: +91-7798364578.*
>>>>>>>
>>>>>>
>>>>>>
>>>>>> --
>>>>>> *Thanks & Regards*
>>>>>> *Akshay Joshi*
>>>>>> *pgAdmin Hacker | Principal Software Architect*
>>>>>> *EDB Postgres <http://edbpostgres.com>*
>>>>>>
>>>>>> *Mobile: +91 976-788-8246*
>>>>>>
>>>>>
>>>>
>>>> --
>>>> *Thanks & Regards*
>>>> *Akshay Joshi*
>>>> *pgAdmin Hacker | Principal Software Architect*
>>>> *EDB Postgres <http://edbpostgres.com>*
>>>>
>>>> *Mobile: +91 976-788-8246*
>>>>
>>>
>>> Regards,
>>> Nikhil Mohite
>>>
>>
>>
>> --
>> *Thanks & Regards*
>> *Akshay Joshi*
>> *pgAdmin Hacker | Principal Software Architect*
>> *EDB Postgres <http://edbpostgres.com>*
>>
>> *Mobile: +91 976-788-8246*
>>
>

--
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Principal Software Architect*
*EDB Postgres <http://edbpostgres.com>*

*Mobile: +91 976-788-8246*