From: | Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com> |
---|---|
To: | Aditya Toshniwal <aditya(dot)toshniwal(at)enterprisedb(dot)com> |
Cc: | Nikhil Mohite <nikhil(dot)mohite(at)enterprisedb(dot)com>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: [pgAdmin][GI-5308]: Cannot set a data field "default", makes it impossible to copy tuples with PK or SERIAL |
Date: | 2022-09-22 09:34:53 |
Message-ID: | CANxoLDdrGo-bVb4TEFS_1ckmNe5e_40MHRr8HTQCXCYh3KOHNw@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Thanks, the patch was applied.
On Wed, Sep 21, 2022 at 1:57 PM Aditya Toshniwal <
aditya(dot)toshniwal(at)enterprisedb(dot)com> wrote:
> Hi,
>
> The patch looks good to me.
>
> On Wed, Sep 21, 2022 at 12:35 PM Nikhil Mohite <
> nikhil(dot)mohite(at)enterprisedb(dot)com> wrote:
>
>> Hi Hackers,
>>
>> PFA updated the patch.
>>
>> On Wed, Sep 21, 2022 at 12:14 PM Aditya Toshniwal <
>> aditya(dot)toshniwal(at)enterprisedb(dot)com> wrote:
>>
>>> Hi Nikhil,
>>>
>>> I think this fix is incomplete. This is not particularly for PK. Non-PK
>>> columns can also have default values.
>>> To cover all, the solution should be if a column which has default value
>>> is made empty then use default and not null.
>>>
>>> On Wed, Sep 21, 2022 at 11:10 AM Nikhil Mohite <
>>> nikhil(dot)mohite(at)enterprisedb(dot)com> wrote:
>>>
>>>> Hi Hackers,
>>>>
>>>> Please find attached the patch for GI-5308
>>>> <https://github.com/pgadmin-org/pgadmin4/issues/5308>: Cannot set a
>>>> data field "default", makes it impossible to copy tuples with PK or SERIAL
>>>>
>>>>
>>>> --
>>>> *Thanks & Regards,*
>>>> *Nikhil Mohite*
>>>> *Senior Software Engineer.*
>>>> *EDB Postgres* <https://www.enterprisedb.com/>
>>>> *Mob.No: +91-7798364578.*
>>>>
>>>
>>>
>>> --
>>> Thanks,
>>> Aditya Toshniwal
>>> pgAdmin Hacker | Software Architect | *edbpostgres.com*
>>> <http://edbpostgres.com>
>>> "Don't Complain about Heat, Plant a TREE"
>>>
>>
>> Regards,
>> Nikhil Mohite
>>
>
>
> --
> Thanks,
> Aditya Toshniwal
> pgAdmin Hacker | Software Architect | *edbpostgres.com*
> <http://edbpostgres.com>
> "Don't Complain about Heat, Plant a TREE"
>
--
Akshay Joshi
Principal Software Architect
+91 9767888246
From | Date | Subject | |
---|---|---|---|
Next Message | Akshay Joshi | 2022-09-22 09:35:02 | Re: [Patch] - #5304 - Add HA options to AWS deployment (RM #7668) |
Previous Message | Akshay Joshi | 2022-09-22 09:34:43 | Re: [pgAdmin][GI-5249]: in Query Editor: Seach and Replace Text Editor |